Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a bug to save model current stats for maxL polarization #5028

Merged
merged 1 commit into from
Feb 28, 2025
Merged

fix a bug to save model current stats for maxL polarization #5028

merged 1 commit into from
Feb 28, 2025

Conversation

yi-fan-wang
Copy link
Member

I think an index idx is missing to save the polarization that gives the maximum likelihood in the polarization marginalization model

cdcapano
cdcapano approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@cdcapano cdcapano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. Looks good to me.

@cdcapano cdcapano merged commit 28d74c0 into gwastro:master Feb 28, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdcapano cdcapano cdcapano approved these changes

@ahnitz ahnitz Awaiting requested review from ahnitz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yi-fan-wang @cdcapano