Skip to content

Commit

Permalink
Update to latest version and fix idempotency issues
Browse files Browse the repository at this point in the history
Signed-off-by: Lance Albertson <[email protected]>
  • Loading branch information
ramereth committed Oct 17, 2020
1 parent 1f6874b commit 3c7c9b3
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 9 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ The `docker_installation_package` resource uses the system package manager to in

```ruby
docker_installation_package 'default' do
version '19.03.8'
version '19.03.13'
action :create
package_options %q|--force-yes -o Dpkg::Options::='--force-confold' -o Dpkg::Options::='--force-all'| # if Ubuntu for example
end
Expand Down
12 changes: 6 additions & 6 deletions kitchen.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ suites:
- name: installation_package
attributes:
docker:
version: '19.03.8'
version: '19.03.13'
run_list:
- recipe[docker_test::installation_package]
excludes:
Expand All @@ -68,7 +68,7 @@ suites:
- name: installation_tarball
attributes:
docker:
version: '19.03.8'
version: '19.03.13'
run_list:
- recipe[docker_test::installation_tarball]

Expand All @@ -82,7 +82,7 @@ suites:
multiple_converge: 1
attributes:
docker:
version: '19.03.8'
version: '19.03.13'
run_list:
- recipe[docker_test::default]
- recipe[docker_test::image]
Expand All @@ -99,7 +99,7 @@ suites:
multiple_converge: 1
attributes:
docker:
version: '19.03.8'
version: '19.03.13'
run_list:
- recipe[docker_test::default]
- recipe[docker_test::network]
Expand All @@ -113,7 +113,7 @@ suites:
multiple_converge: 1
attributes:
docker:
version: '19.03.8'
version: '19.03.13'
run_list:
- recipe[docker_test::default]
- recipe[docker_test::volume]
Expand All @@ -127,7 +127,7 @@ suites:
multiple_converge: 1
attributes:
docker:
version: '19.03.8'
version: '19.03.13'
run_list:
- recipe[docker_test::default]
- recipe[docker_test::registry]
Expand Down
2 changes: 1 addition & 1 deletion spec/docker_test/installation_package_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

context 'testing default action, default properties' do
it 'installs docker' do
expect(chef_run).to create_docker_installation_package('default').with(version: '19.03.8')
expect(chef_run).to create_docker_installation_package('default').with(version: '19.03.13')
end
end

Expand Down
3 changes: 2 additions & 1 deletion test/cookbooks/docker_test/recipes/installation_package.rb
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
docker_installation_package 'default' do
version '19.03.8' unless platform_family?('fedora') # Fedora doesn't have this version
# Include epoch on RHEL to fix idempotency issues
version platform_family?('rhel', 'fedora') ? '3:19.03.13' : '19.03.13'
action :create
end

0 comments on commit 3c7c9b3

Please sign in to comment.