fix(core): include dependencies of projects which do not have a target (

nrwl#6309)
gxxcastillo · Jul 9, 2021 · 0335797 · 0335797
1 parent d35d03e
commit 0335797
Show file tree

Hide file tree

Showing 5 changed files with 596 additions and 35 deletions.
diff --git a/packages/workspace/src/tasks-runner/__snapshots__/task-graph-creator.spec.ts.snap b/packages/workspace/src/tasks-runner/__snapshots__/task-graph-creator.spec.ts.snap
@@ -1,5 +1,113 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
+exports[`TaskGraphCreator (tasks with dependency configurations) should create a task graph (builds depend on builds of dependencies even with intermediate projects) 1`] = `
+Object {
+  "dependencies": Object {
+    "app1:build": Array [
+      "common2:build",
+    ],
+    "common2:build": Array [],
+  },
+  "roots": Array [
+    "common2:build",
+  ],
+  "tasks": Object {
+    "app1:build": Object {
+      "id": "app1:build",
+      "overrides": Object {},
+      "projectRoot": "app1-root",
+      "target": Object {
+        "configuration": undefined,
+        "project": "app1",
+        "target": "build",
+      },
+    },
+    "common2:build": Object {
+      "id": "common2:build",
+      "overrides": Object {},
+      "projectRoot": "common2-root",
+      "target": Object {
+        "configuration": undefined,
+        "project": "common2",
+        "target": "build",
+      },
+    },
+  },
+}
+`;
+
+exports[`TaskGraphCreator (tasks with dependency configurations) should create a task graph (builds depend on builds of dependencies with intermediate projects and circular dependencies between projects) 1`] = `
+Object {
+  "dependencies": Object {
+    "app1:build": Array [
+      "common2:build",
+    ],
+    "common2:build": Array [],
+  },
+  "roots": Array [
+    "common2:build",
+  ],
+  "tasks": Object {
+    "app1:build": Object {
+      "id": "app1:build",
+      "overrides": Object {},
+      "projectRoot": "app1-root",
+      "target": Object {
+        "configuration": undefined,
+        "project": "app1",
+        "target": "build",
+      },
+    },
+    "common2:build": Object {
+      "id": "common2:build",
+      "overrides": Object {},
+      "projectRoot": "common2-root",
+      "target": Object {
+        "configuration": undefined,
+        "project": "common2",
+        "target": "build",
+      },
+    },
+  },
+}
+`;
+
+exports[`TaskGraphCreator (tasks with dependency configurations) should create a task graph (builds depend on builds of dependencies with intermediate projects and circular dependencies between projects) 2 1`] = `
+Object {
+  "dependencies": Object {
+    "app1:build": Array [
+      "common3:build",
+    ],
+    "common3:build": Array [],
+  },
+  "roots": Array [
+    "common3:build",
+  ],
+  "tasks": Object {
+    "app1:build": Object {
+      "id": "app1:build",
+      "overrides": Object {},
+      "projectRoot": "app1-root",
+      "target": Object {
+        "configuration": undefined,
+        "project": "app1",
+        "target": "build",
+      },
+    },
+    "common3:build": Object {
+      "id": "common3:build",
+      "overrides": Object {},
+      "projectRoot": "common3",
+      "target": Object {
+        "configuration": undefined,
+        "project": "common3",
+        "target": "build",
+      },
+    },
+  },
+}
+`;
+
 exports[`TaskGraphCreator (tasks with dependency configurations) should create task graph (builds depend on build of dependencies and prebuild of self) 1`] = `
 Object {
   "dependencies": Object {