feat(angular): enable minimization for MFEs (nrwl#8135)

* feat(angular): enable minimization for MFEs * fix(angular): test snapshots
gxxcastillo · Dec 13, 2021 · 5339e99 · 5339e99
1 parent 7ca6b29
commit 5339e99
Show file tree

Hide file tree

Showing 7 changed files with 24 additions and 9 deletions.
diff --git a/packages/angular/src/generators/application/__snapshots__/application.spec.ts.snap b/packages/angular/src/generators/application/__snapshots__/application.spec.ts.snap
@@ -30,7 +30,6 @@ module.exports = {
   },
   optimization: {
     runtimeChunk: false,
-    minimize: false,
   },
   experiments: {
     outputModule: true
@@ -94,7 +93,6 @@ module.exports = {
   },
   optimization: {
     runtimeChunk: false,
-    minimize: false,
   },
   experiments: {
     outputModule: true
@@ -157,7 +155,6 @@ module.exports = {
   },
   optimization: {
     runtimeChunk: false,
-    minimize: false,
   },
   experiments: {
     outputModule: true
@@ -219,7 +216,6 @@ module.exports = {
   },
   optimization: {
     runtimeChunk: false,
-    minimize: false,
   },
   experiments: {
     outputModule: true

diff --git a/packages/angular/src/generators/application/lib/update-config-files.ts b/packages/angular/src/generators/application/lib/update-config-files.ts
@@ -25,6 +25,7 @@ function updateTsConfigOptions(host: Tree, options: NormalizedSchema) {
     compilerOptions: {
       ...json.compilerOptions,
       outDir: `${offsetFromRoot(options.appProjectRoot)}dist/out-tsc`,
+      target: 'ES2017',
     },
     exclude: [
       ...new Set([...(json.exclude || []), '**/*.test.ts', '**/*.spec.ts']),

diff --git a/packages/angular/src/generators/setup-mfe/__snapshots__/setup-mfe.spec.ts.snap b/packages/angular/src/generators/setup-mfe/__snapshots__/setup-mfe.spec.ts.snap
@@ -60,7 +60,6 @@ module.exports = {
   },
   optimization: {
     runtimeChunk: false,
-    minimize: false,
   },
   experiments: {
     outputModule: true
@@ -124,7 +123,6 @@ module.exports = {
   },
   optimization: {
     runtimeChunk: false,
-    minimize: false,
   },
   experiments: {
     outputModule: true
@@ -187,7 +185,6 @@ module.exports = {
   },
   optimization: {
     runtimeChunk: false,
-    minimize: false,
   },
   experiments: {
     outputModule: true
@@ -249,7 +246,6 @@ module.exports = {
   },
   optimization: {
     runtimeChunk: false,
-    minimize: false,
   },
   experiments: {
     outputModule: true

diff --git a/packages/angular/src/generators/setup-mfe/files/webpack/webpack.config.js__tmpl__ b/packages/angular/src/generators/setup-mfe/files/webpack/webpack.config.js__tmpl__
@@ -27,7 +27,6 @@ module.exports = {
   },
   optimization: {
     runtimeChunk: false,
-    minimize: false,
   },
   experiments: {
     outputModule: true

diff --git a/packages/angular/src/generators/setup-mfe/lib/index.ts b/packages/angular/src/generators/setup-mfe/lib/index.ts
@@ -5,4 +5,5 @@ export * from './change-build-target';
 export * from './fix-bootstrap';
 export * from './generate-config';
 export * from './get-remotes-with-ports';
+export * from './set-tsconfig-target';
 export * from './setup-serve-target';
diff --git a/packages/angular/src/generators/setup-mfe/lib/set-tsconfig-target.ts b/packages/angular/src/generators/setup-mfe/lib/set-tsconfig-target.ts
@@ -0,0 +1,20 @@
+import type { Tree } from '@nrwl/devkit';
+import type { Schema } from '../schema';
+
+import {
+  updateJson,
+  readProjectConfiguration,
+  joinPathFragments,
+} from '@nrwl/devkit';
+
+export function updateTsConfigTarget(tree: Tree, schema: Schema) {
+  const { root } = readProjectConfiguration(tree, schema.appName);
+  // tsconfig.app.json
+  updateJson(tree, joinPathFragments(root, `tsconfig.app.json`), (json) => ({
+    ...json,
+    compilerOptions: {
+      ...json.compilerOptions,
+      target: 'ES2020',
+    },
+  }));
+}
diff --git a/packages/angular/src/generators/setup-mfe/setup-mfe.ts b/packages/angular/src/generators/setup-mfe/setup-mfe.ts
@@ -16,6 +16,7 @@ import {
   generateWebpackConfig,
   getRemotesWithPorts,
   setupServeTarget,
+  updateTsConfigTarget,
 } from './lib';
 import { angularArchitectsModuleFederationPluginVersion } from '../../utils/versions';
 
@@ -30,6 +31,7 @@ export async function setupMfe(host: Tree, options: Schema) {
   addEntryModule(host, options, projectConfig.root);
   addImplicitDeps(host, options);
   changeBuildTarget(host, options);
+  updateTsConfigTarget(host, options);
   setupServeTarget(host, options);
 
   fixBootstrap(host, projectConfig.root);