Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow for missing values in Julia #70

Merged
merged 1 commit into from
Jan 22, 2019
Merged

Do not allow for missing values in Julia #70

merged 1 commit into from
Jan 22, 2019

Conversation

nalimilan
Copy link
Contributor

One of the strengths of Julia is that it supports both columns which cannot contain missing values and columns that can, allowing for better performance when there are no missing values.

One could also use allowmissing=:auto to leave CSV.read choose automatically depending on whether missing values have been encountered (this isn't used by default since it can fail if no missing values appear in the subset of rows used for detection).

One of the strengths of Julia is that it supports both columns which cannot contain missing values and columns that can, allowing for better performance when there are no missing values.
@jangorecki
Copy link
Contributor

jangorecki commented Jan 22, 2019

Thanks. I will merge it for now but sooner or later we will add missing values tests #40 so it will need to be reverted then.

@jangorecki jangorecki merged commit 64d55b8 into h2oai:master Jan 22, 2019
@nalimilan nalimilan deleted the patch-1 branch January 22, 2019 18:36
@nalimilan
Copy link
Contributor Author

OK. It could make sense to have separate tests with and without missing values. allowmissing=:auto should automatically choose the column type depending on whether it contains missing values or not, so both kinds of columns can be tested easily in the same script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants