Address PR Comments

h39s · Feb 3, 2023 · 413e559 · 413e559
1 parent cef76b2
commit 413e559
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 11 deletions.
diff --git a/src/__tests__/unit_tests/PresetListItem.test.tsx b/src/__tests__/unit_tests/PresetListItem.test.tsx
@@ -102,7 +102,7 @@ describe('PresetListItem', () => {
   it('should handle change with format change', async () => {
     const testValue = 'Standard';
     const newValue = 'tO p$RoPeR /cAsInG -_';
-    const expectedNewValue = 'To proper casing -_';
+    const expectedNewValue = 'tO pRoPeR cAsInG -_';
     const { user } = setup(
       <PresetListItem
         value={testValue}

diff --git a/src/common/utils.ts b/src/common/utils.ts
@@ -23,11 +23,3 @@ export const computeAvgFreq = (filters: IFilter[], index: number) => {
 // have manually confirmed this.
 export const isRestrictedPresetName = (newName: string) =>
   RESERVED_FILE_NAMES_SET.has(newName.toUpperCase());
-
-export const isDuplicatePresetName = (
-  newName: string,
-  existingNames: string[]
-) =>
-  existingNames.some(
-    (oldValue) => newName.toLowerCase() === oldValue.toLowerCase()
-  );
diff --git a/src/renderer/PresetsBar.tsx b/src/renderer/PresetsBar.tsx
@@ -235,6 +235,7 @@ const PresetsBar = () => {
           isDisabled={!!globalError}
           errorMessage={newPresetNameError}
           handleChange={handleChangeNewPresetName}
+          formatInput={formatPresetName}
         />
       </div>
       <Button

diff --git a/src/renderer/components/PresetListItem.tsx b/src/renderer/components/PresetListItem.tsx
@@ -56,6 +56,7 @@ const PresetListItem = ({
           errorMessage={errorMessage}
           handleChange={handleInputChange}
           handleEscape={handleEscape}
+          formatInput={formatPresetName}
           updateOnSubmitOnly
         />
       ) : (

diff --git a/src/renderer/utils/utils.ts b/src/renderer/utils/utils.ts
@@ -17,8 +17,7 @@ export const range = (start: number, stop: number, step: number) =>
   Array.from({ length: (stop - start) / step + 1 }, (_, i) => start + i * step);
 
 export const formatPresetName = (s: string) => {
-  const filteredS = s.replace(/[^a-zA-Z0-9|_|\-| ]+/, '');
-  return filteredS.slice(0, 1).toUpperCase() + filteredS.slice(1).toLowerCase();
+  return s.replace(/[^a-zA-Z0-9|_|\-| ]+/, '');
 };
 
 // *** CUSTOM HOOKS ***