Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass openCallback events to public API: addOnOpenListener #28

Closed
e271828- opened this issue Apr 25, 2022 · 1 comment
Closed

pass openCallback events to public API: addOnOpenListener #28

e271828- opened this issue Apr 25, 2022 · 1 comment
Assignees
@CAMOBAP

Comments

@e271828-
Copy link
Contributor

Goal: we want to let apps capture the open-callback event that's bound to openCallback currently. This enables analytics and tracking.
CAMOBAP added a commit that referenced this issue Apr 27, 2022
@CAMOBAP
#28 add addOnOpenListener for open-callback events
9483154
@CAMOBAP CAMOBAP mentioned this issue Apr 27, 2022
Merged
CAMOBAP added a commit that referenced this issue Apr 28, 2022
@CAMOBAP
#28 put back iternal OnLoadedListener
8c1d9e2
@e271828- e271828- mentioned this issue May 3, 2022
Closed
CAMOBAP added a commit that referenced this issue May 3, 2022
@CAMOBAP
#28 fix PR suggestions
2c706f2 
 - wrong function name for onLoaded
 - logging statement for onLoaded stub function
CAMOBAP added a commit that referenced this issue May 3, 2022
@CAMOBAP
#28 remove debug logging from JS and don't drop listeners after open …
df96c03 
…event is happens
e271828- added a commit that referenced this issue May 4, 2022
@CAMOBAP @e271828-
#28 add addOnOpenListener for open-callback events (#30)
76af5d2 
* #28 add addOnOpenListener for open-callback events

* Improve documentation for addOnOpenListener API

Co-authored-by: e271828- <[email protected]>

* #28 put back iternal OnLoadedListener

* #28 fix PR suggestions

 - wrong function name for onLoaded
 - logging statement for onLoaded stub function

* #28 remove debug logging from JS and don't drop listeners after open event is happens

* Improve open-callback docs

Co-authored-by: e271828- <[email protected]>

* Bump version 2.2.0

Co-authored-by: e271828- <[email protected]>
@CAMOBAP CAMOBAP mentioned this issue May 11, 2022
Closed
@CAMOBAP
Copy link
Collaborator

CAMOBAP commented May 11, 2022

Done

@CAMOBAP CAMOBAP closed this as completed May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CAMOBAP CAMOBAP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CAMOBAP @e271828-