Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#28 add addOnOpenListener for open-callback events #30

Merged
merged 8 commits into from
May 4, 2022
Merged

#28 add addOnOpenListener for open-callback events #30

merged 8 commits into from
May 4, 2022

Conversation

CAMOBAP
Copy link
Collaborator

@CAMOBAP CAMOBAP commented Apr 27, 2022

Notes:

  • Previously we had an 'internal' onLoaded callback, but due to intersection with open-callback event functionality I have replaced it with onOpen callback instead to keep it more clear

@CAMOBAP CAMOBAP requested review from e271828- and DSergiu April 27, 2022 08:59
@CAMOBAP CAMOBAP self-assigned this Apr 27, 2022
e271828-
e271828- reviewed Apr 27, 2022
View reviewed changes
@CAMOBAP CAMOBAP requested review from e271828- and DSergiu April 28, 2022 08:37
@CAMOBAP
Merge branch 'feature/open-callback-api' of github.com:hCaptcha/hcapt…
97ea5f4 
…cha-android-sdk into feature/open-callback-api
@CAMOBAP CAMOBAP force-pushed the feature/open-callback-api branch from 7c0e5fa to 97ea5f4 Compare April 28, 2022 08:51
@CAMOBAP CAMOBAP requested a review from DSergiu April 28, 2022 08:59
@CAMOBAP
#28 fix PR suggestions
2c706f2 
 - wrong function name for onLoaded
 - logging statement for onLoaded stub function
@e271828-
Copy link
Contributor

e271828- commented May 3, 2022

@CAMOBAP please bump version as well.

e271828-
e271828- reviewed May 3, 2022
View reviewed changes
@e271828- e271828- requested a review from DSergiu May 3, 2022 14:08
e271828-
e271828- reviewed May 3, 2022
View reviewed changes
Copy link
Contributor

@e271828- e271828- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, will defer to @DSergiu

DSergiu
DSergiu approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@DSergiu DSergiu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment, non-blocker. Otherwise, this looks good! Nice job.

@e271828- e271828- merged commit 76af5d2 into main May 4, 2022
@e271828- e271828- deleted the feature/open-callback-api branch May 4, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e271828- e271828- e271828- left review comments

@DSergiu DSergiu DSergiu approved these changes

Assignees

@CAMOBAP CAMOBAP

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CAMOBAP @e271828- @DSergiu