Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add token timeout error #46

Merged
merged 11 commits into from
Jul 13, 2022
Merged

Conversation

CAMOBAP
Copy link
Collaborator

@CAMOBAP CAMOBAP commented Jun 25, 2022

closes #45

@CAMOBAP CAMOBAP requested review from e271828- and DSergiu June 25, 2022 17:58
@CAMOBAP CAMOBAP self-assigned this Jun 25, 2022
@github-actions
Copy link

github-actions bot commented Jun 25, 2022

Diffuse report:

OLD: sdk-main.aar
NEW: sdk-pr.aar

 AAR      │ old       │ new       │ diff     
──────────┼───────────┼───────────┼──────────
      jar │  33.2 KiB │  34.7 KiB │ +1.4 KiB 
 manifest │     385 B │     385 B │      0 B 
      res │  78.2 KiB │  78.2 KiB │      0 B 
    other │  75.6 KiB │  75.6 KiB │      0 B 
──────────┼───────────┼───────────┼──────────
    total │ 194.6 KiB │ 195.9 KiB │ +1.3 KiB 

 JAR     │ old │ new │ diff          
─────────┼─────┼─────┼───────────────
 classes │  28 │  29 │  +1 (+1 -0)   
 methods │ 345 │ 359 │ +14 (+26 -12) 
  fields │ 125 │ 133 │  +8 (+8 -0)
AAR
 size     │ diff     │ path                        
──────────┼──────────┼─────────────────────────────
 34.7 KiB │ +1.4 KiB │ ∆ classes.jar               
  7.1 KiB │   -125 B │ ∆ assets/hcaptcha-form.html 
──────────┼──────────┼─────────────────────────────
 41.8 KiB │ +1.3 KiB │ (total)
JAR
CLASSES:

   old │ new │ diff       
  ─────┼─────┼────────────
   28  │ 29  │ +1 (+1 -0) 
  + com.hcaptcha.sdk.tasks.Task_1
  

METHODS:

   old │ new │ diff          
  ─────┼─────┼───────────────
   345 │ 359 │ +14 (+26 -12) 
  + com.hcaptcha.sdk.HCaptcha access_100(HCaptcha) → HCaptchaConfig
  + com.hcaptcha.sdk.HCaptcha access_200(HCaptcha, long)
  + com.hcaptcha.sdk.HCaptcha access_300(HCaptcha) → Handler
  + com.hcaptcha.sdk.HCaptcha access_400(HCaptcha, Object)
  + com.hcaptcha.sdk.HCaptcha access_500(HCaptcha, HCaptchaException)
  + com.hcaptcha.sdk.HCaptcha startVerification() → HCaptcha
  + com.hcaptcha.sdk.HCaptcha_1 onSuccess(String)
  + com.hcaptcha.sdk.HCaptchaConfig _default_tokenExpiration() → long
  + com.hcaptcha.sdk.HCaptchaConfig <init>(String, Boolean, Boolean, Boolean, String, String, String, String, String, String, String, HCaptchaSize, HCaptchaTheme, String, String, Boolean, long)
  + com.hcaptcha.sdk.HCaptchaConfig access_1000() → long
  + com.hcaptcha.sdk.HCaptchaConfig getTokenExpiration() → long
  + com.hcaptcha.sdk.HCaptchaConfig setTokenExpiration(long)
  + com.hcaptcha.sdk.HCaptchaConfig_HCaptchaConfigBuilder tokenExpiration(long) → HCaptchaConfig_HCaptchaConfigBuilder
  + com.hcaptcha.sdk.HCaptchaDialogFragment onSuccess(String)
  + com.hcaptcha.sdk.HCaptchaHeadlessWebView onSuccess(String)
  + com.hcaptcha.sdk.HCaptchaStateListener onSuccess(String)
  + com.hcaptcha.sdk.HCaptchaTokenResponse <init>(String, Handler)
  + com.hcaptcha.sdk.HCaptchaTokenResponse markUsed()
  + com.hcaptcha.sdk.tasks.Task access_000(Task) → List
  + com.hcaptcha.sdk.tasks.Task scheduleCaptchaExpired(long)
  + com.hcaptcha.sdk.tasks.Task_1 <init>(Task)
  + com.hcaptcha.sdk.tasks.Task_1 run()
  + android.os.Handler postDelayed(Runnable, long) → boolean
  + android.os.Handler removeCallbacksAndMessages(Object)
  + java.lang.StringBuilder append(long) → StringBuilder
  + java.util.concurrent.TimeUnit toMillis(long) → long
  
  - com.hcaptcha.sdk.HCaptcha access_100(HCaptcha, Object)
  - com.hcaptcha.sdk.HCaptcha access_200(HCaptcha, HCaptchaException)
  - com.hcaptcha.sdk.HCaptcha_1 onSuccess(HCaptchaTokenResponse)
  - com.hcaptcha.sdk.HCaptchaConfig <init>(String, Boolean, Boolean, Boolean, String, String, String, String, String, String, String, HCaptchaSize, HCaptchaTheme, String, String, Boolean)
  - com.hcaptcha.sdk.HCaptchaDialogFragment onSuccess(HCaptchaTokenResponse)
  - com.hcaptcha.sdk.HCaptchaHeadlessWebView onSuccess(HCaptchaTokenResponse)
  - com.hcaptcha.sdk.HCaptchaStateListener onSuccess(HCaptchaTokenResponse)
  - com.hcaptcha.sdk.HCaptchaTokenResponse <init>(String)
  - com.hcaptcha.sdk.HCaptchaTokenResponse canEqual(Object) → boolean
  - com.hcaptcha.sdk.HCaptchaTokenResponse equals(Object) → boolean
  - com.hcaptcha.sdk.HCaptchaTokenResponse hashCode() → int
  - com.hcaptcha.sdk.HCaptchaTokenResponse toString() → String
  

FIELDS:

   old │ new │ diff       
  ─────┼─────┼────────────
   125 │ 133 │ +8 (+8 -0) 
  + com.hcaptcha.sdk.HCaptchaConfig tokenExpiration: long
  + com.hcaptcha.sdk.HCaptchaConfig_HCaptchaConfigBuilder tokenExpiration_set: boolean
  + com.hcaptcha.sdk.HCaptchaConfig_HCaptchaConfigBuilder tokenExpiration_value: long
  + com.hcaptcha.sdk.HCaptchaError TOKEN_TIMEOUT: HCaptchaError
  + com.hcaptcha.sdk.HCaptchaTokenResponse handler: Handler
  + com.hcaptcha.sdk.tasks.Task handler: Handler
  + com.hcaptcha.sdk.tasks.Task_1 this_0: Task
  + java.util.concurrent.TimeUnit SECONDS: TimeUnit

@CAMOBAP
Copy link
Collaborator Author

CAMOBAP commented Jun 25, 2022

@DSergiu @e271828- I know that #45 was created in favor of #31 but to me, #31 approach has some benefits over #45:

  • less boilerplate code
  • better extensibility
  • a bit less AAR (-200kb)
  • iOS implementation uses the same approach (one callback for multiple events)

Let me know how do you think

*CI is red there right now, I will fix it if it make sens

@CAMOBAP CAMOBAP marked this pull request as ready for review June 25, 2022 19:31
@CAMOBAP
Copy link
Collaborator Author

CAMOBAP commented Jun 30, 2022

@e271828- @DSergiu ready for review again

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DSergiu DSergiu changed the title #45 expired, challengeExpired and close callbacks added to public API feat: add token timeout error Jul 13, 2022
@DSergiu DSergiu merged commit 7966fea into main Jul 13, 2022
@DSergiu DSergiu deleted the feature/close-exlipred-callbacks branch July 13, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose remaining callbacks for listeners
3 participants