update with requested changes

hackartists · Jan 25, 2023 · a71a19a · a71a19a
1 parent fdc962f
commit a71a19a
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,7 +9,7 @@
 - Lint rule for banning "console.sol" and "import hardhat or foundry console.sol" [#372](https://github.com/protofire/solhint/pull/372)
 
 ### Fixed
-- Directories with .sol in the name path treated as files [#352]()
+- Directories with .sol in the name path treated as files [#352](https://github.com/protofire/solhint/pull/388)
 
 <br><br>
 ## [3.3.8] - 2023-01-17

diff --git a/...l-on-path/contracts/ERC20.sol/Foo.sol.sol → ...otSol-on-path/contracts/ERC20.sol/Foo.sol b/...l-on-path/contracts/ERC20.sol/Foo.sol.sol → ...otSol-on-path/contracts/ERC20.sol/Foo.sol
diff --git a/e2e/test.js b/e2e/test.js
@@ -115,12 +115,10 @@ describe('e2e', function() {
   describe('.sol on path', function() {
     useFixture('04-dotSol-on-path')
 
-    it('should success', function() {
-      const { code, stdout } = shell.exec('solhint contracts/**/*.sol')
+    it('should handle directory names that end with .sol', function() {
+      const { code } = shell.exec('solhint contracts/**/*.sol')
 
       expect(code).to.equal(0)
-
-      console.log(stdout)
     })
   })
 })
diff --git a/lib/index.js b/lib/index.js
@@ -61,7 +61,7 @@ function processFile(file, config) {
 function processPath(path, config) {
   const ignoreFilter = ignore({ allowRelativePaths: true }).add(config.excludedFiles)
 
-  const allFiles = glob.sync(path, {}).filter((f) => fs.lstatSync(f).isFile())
+  const allFiles = glob.sync(path, { nodir: true })
   const files = ignoreFilter.filter(allFiles)
 
   return files.map((curFile) => processFile(curFile, config))