Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store a copy of gallery images to avoid re-fetching #1735

Merged
merged 10 commits into from
Jun 13, 2024
Merged

Conversation

JosiasAurel
Copy link
Contributor

@JosiasAurel JosiasAurel commented Jun 3, 2024

#1396

Right now, every time you perform a search the game thumbnail is re-fetched from the server.

Now game image data is generated at build time and stored in the public folder. These image data are cached through vercel resulting in less resources transferred.

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sprig ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 13, 2024 2:09pm

Copy link
Contributor

@grymmy grymmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test that this doesn't cause issues in worst case scenarios

@JosiasAurel
Copy link
Contributor Author

now game image data is generated on the server-side and stored in .json files stored in the public directory.
the gallery will fetch this json files which are cached (max age is 30 minutes) through vercel which leads to less resources transferred

@JosiasAurel JosiasAurel requested a review from grymmy June 10, 2024 10:49
Copy link
Contributor

@grymmy grymmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve / respond / think about to my other comments before landing.

vercel.json Show resolved Hide resolved
src/integrations/thumbnail.ts Show resolved Hide resolved
src/integrations/thumbnail.ts Outdated Show resolved Hide resolved
@JosiasAurel JosiasAurel merged commit e08b008 into main Jun 13, 2024
2 checks passed
@JosiasAurel JosiasAurel deleted the feat/gallery branch June 13, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants