-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
store a copy of gallery images to avoid re-fetching #1735
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please test that this doesn't cause issues in worst case scenarios
now game image data is generated on the server-side and stored in .json files stored in the public directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve / respond / think about to my other comments before landing.
135dedf
to
64277f7
Compare
#1396
Right now, every time you perform a search the game thumbnail is re-fetched from the server.
Now game image data is generated at build time and stored in the public folder. These image data are cached through vercel resulting in less resources transferred.