Skip to content

Commit

Permalink
doc: make chart.apis.google.com link not clickable
Browse files Browse the repository at this point in the history
The example in the 'A web server' section of the effective Go document
uses Google's image charts API (at chart.apis.google.com).

The service is now deprecated (see developers.google.com/chart/image),
and visiting http://chart.apis.google.com gives a 404. The endpoint is
still active, so the Go code in the example still works, but there's
no point in making the link clickable by the user if the page returns
a 404.

Change the element to `<code>`.

Change-Id: Ie67f4723cfa636e3dc1460507055b6bbb2b0970c
Reviewed-on: https://go-review.googlesource.com/109576
Reviewed-by: Brad Fitzpatrick <[email protected]>
  • Loading branch information
ALTree committed Apr 26, 2018
1 parent 353bba3 commit a3bafcf
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions doc/effective_go.html
Original file line number Diff line number Diff line change
Expand Up @@ -3588,8 +3588,7 @@ <h2 id="web_server">A web server</h2>
<p>
Let's finish with a complete Go program, a web server.
This one is actually a kind of web re-server.
Google provides a service at
<a href="http://chart.apis.google.com">http://chart.apis.google.com</a>
Google provides a service at <code>chart.apis.google.com</code>
that does automatic formatting of data into charts and graphs.
It's hard to use interactively, though,
because you need to put the data into the URL as a query.
Expand Down

0 comments on commit a3bafcf

Please sign in to comment.