Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new condition in Terms of Conditions #938

Merged
merged 7 commits into from
Nov 15, 2024
Merged

Conversation

JamieXiao
Copy link
Contributor

Tickets:

  • HAC-

List of changes:

  • Added a sendEmail boolean field under the Terms of Conditions section of the application form. The following files were changed: api_data, hacker.validator, validator.helper, hacker.model, hacker, hacker.test.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this been tested?

run the hackerAPI and dashboard under the Terms and Conditions section of the application form.

Test Configuration:

Firmware version:
Hardware:
Toolchain:
SDK:

Questions for code reviewers?

I am not sure how to check if the boolean in the new condition (sendEmail) properly changes depending on the user in the database.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Listed change(s) in the Changelog
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hacker-api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 3:04am

Copy link
Contributor

@tektaxi tektaxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tektaxi tektaxi merged commit 175271b into dev Nov 15, 2024
2 of 3 checks passed
@tektaxi tektaxi deleted the feat/termsAndConditions branch November 15, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants