Small fix of rename condition on VM

The condition status should be one of: "True", "False" or "Unknown". The type should probably not contain space. Signed-off-by: Andrej Krejcir <[email protected]>
haemyung · Mar 26, 2020 · 2740a1f · 2740a1f
1 parent 230a99b
commit 2740a1f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/virt-controller/watch/vm.go b/pkg/virt-controller/watch/vm.go
@@ -324,7 +324,7 @@ func (c *VMController) handleVMRenameRequest(vm *virtv1.VirtualMachine, newName
 	newVM.Status.Conditions = []virtv1.VirtualMachineCondition{
 		{
 			Type:    virtv1.RenameConditionType,
-			Status:  "Success",
+			Status:  k8score.ConditionTrue,
 			Reason:  vm.Name,
 			Message: fmt.Sprintf("This VM was renamed, the old name was %s", vm.Name),
 		},

diff --git a/staging/src/kubevirt.io/client-go/api/v1/types.go b/staging/src/kubevirt.io/client-go/api/v1/types.go
@@ -947,7 +947,7 @@ const (
 	VirtualMachinePaused VirtualMachineConditionType = "Paused"
 
 	// This condition indicates that the VM was renamed
-	RenameConditionType VirtualMachineConditionType = "Rename Operation"
+	RenameConditionType VirtualMachineConditionType = "RenameOperation"
 )
 
 // ---