Skip to content

Commit

Permalink
Move unistd.h include to cpp where its used (facebook#25107)
Browse files Browse the repository at this point in the history
Summary:
unistd.h isn't a header available in the windows SDK, so we can't include it from react-native-windows.

I moved the usage of dup, to JSBigString.cpp in a previous PR, so this header should only be needed in the cpp file, not the header.  (And react-native-windows doesn't use the cpp file)

## Changelog

[Internal] [Fixed] - Header cleanup
Pull Request resolved: facebook#25107

Differential Revision: D15602265

Pulled By: cpojer

fbshipit-source-id: 6a62bf8fe6758e400810f37834e8646485120d71
  • Loading branch information
acoates-ms authored and facebook-github-bot committed Jun 3, 2019
1 parent a98772e commit 7f489b6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions ReactCommon/cxxreact/JSBigString.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

#include <fcntl.h>
#include <sys/stat.h>
#include <unistd.h>

#include <glog/logging.h>

Expand Down
1 change: 0 additions & 1 deletion ReactCommon/cxxreact/JSBigString.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#pragma once

#include <fcntl.h>
#include <unistd.h>
#include <sys/mman.h>

#include <folly/Exception.h>
Expand Down

0 comments on commit 7f489b6

Please sign in to comment.