Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libsearpc.pc.in #20

Closed
wants to merge 1 commit into from
Closed

Update libsearpc.pc.in #20

wants to merge 1 commit into from

Conversation

cicku
Copy link

@cicku cicku commented Aug 25, 2014

DESTDIR shouldn't be used in PKG-CONFIG file. All $(DESTDIR) variables should only be used in Makefile. If users want to install the file into special location, let them choose the prefix before configure.

And if you have dependencies with specific version requirements, it's better to write them in the pc as well.

DESTDIR shouldn't be used in PKG-CONFIG file. All $(DESTDIR) variables should only be used in Makefile. If users want to install the file into special location, let them choose the prefix before configure.

And if you have dependencies with specific version requirements, it's better to write them in the pc as well.
@lins05
Copy link
Contributor

lins05 commented Aug 25, 2014

First thank your for this PR!

For the DESTDIR problem, please refer to haiwen/seafile#532

The other changes looks good to me.

@cicku
Copy link
Author

cicku commented Aug 25, 2014

I still don't get it because the way you handle the pkgconfig is non-standard. This would increase the downstream packagers' work albeit petty.

Anyway, you can merge other parts. But don't forget to update them when you change the requirements.

Thanks.

@vitlav
Copy link

vitlav commented Mar 3, 2024

DESTDIR is still there:
prefix=(DESTDIR)@Prefix

@vitlav
Copy link

vitlav commented Mar 3, 2024

But don't forget to update them when you change the requirements
You have to use a variables like
GLIB_REQUIRED=2.26.0
from configure.ac here.
The libsearpc.pc.in file specially has .in extension to get replacements.

@killing
Copy link
Member

killing commented Apr 19, 2024

Updated in #66

@killing killing closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants