Unstagnant eip 634 (ethereum#4429)

* Updated EIP-2098 compact representation with suggestions and moved to review. * Move EIP-634 from Stagnant to Draft. * Updated fields to be up-to-date with current EIP standards. * Updated function style. * Updated per suggestions. * Update EIPS/eip-634.md Co-authored-by: Alex Beregszaszi <[email protected]>
hamidehFakhr · Dec 5, 2021 · cbabc3c · cbabc3c
1 parent 3739b29
commit cbabc3c
Showing 1 changed file with 16 additions and 8 deletions.
diff --git a/EIPS/eip-634.md b/EIPS/eip-634.md
@@ -1,12 +1,14 @@
 ---
 eip: 634
 title: Storage of text records in ENS
+description: Profiles for ENS resolvers to store arbitrary text key/value pairs.
 author: Richard Moore (@ricmoo)
 type: Standards Track
 discussions-to: https://github.com/ethereum/EIPs/issues/2439
 category: ERC
-status: Stagnant
+status: Draft
 created: 2017-05-17
+requires: 137, 165
 ---
 
 ## Abstract
@@ -29,9 +31,17 @@ associate arbitrary key-value text.
 
 A new resolver interface is defined, consisting of the following method:
 
-    function text(bytes32 node, string key) constant returns (string text);
+```solidity
+interface IERC634 {
+  /// @notice Returns the text data associated with a key for an ENS name
+  /// @param node A nodehash for an ENS name
+  /// @param key A key to lookup text data for
+  /// @return The text data
+  function text(bytes32 node, string key) view returns (string text);
+}
+```
 
-The interface ID of this interface is 0x59d1d43c.
+The [EIP-165](./eip-165.md) interface ID of this interface is `0x59d1d43c`.
 
 The `text` data may be any arbitrary UTF-8 string. If the key is not present, the empty string
 must be returned.
@@ -50,7 +60,7 @@ the hyphen (-).
 - **mail** - A physical mailing address
 - **notice** - A notice regarding this name
 - **location** - A generic location (e.g. `"Toronto, Canada"`)
-- **phone** - A phone number as an [E.164](https://en.wikipedia.org/wiki/E.164) string
+- **phone** - A phone number as an E.164 string
 - **url** - a website URL
 
 ### Service Keys
@@ -111,11 +121,9 @@ allowing applications to use custom keys for their own purposes.
 Not applicable.
 
 
-## Test Cases
-TBD
+## Security Considerations
+None.
 
-## Implementation
-None yet.
 
 ## Copyright
 Copyright and related rights waived via [CC0](https://creativecommons.org/publicdomain/zero/1.0/).