Skip to content

Commit

Permalink
Remove jQuery from the issue reference context popup (go-gitea#29367)
Browse files Browse the repository at this point in the history
- Removed all jQuery calls
- Tested the context popup functionality and it works as before

# Demo without jQuery

![action](https://github.com/go-gitea/gitea/assets/20454870/90b53de5-a8e9-4ed7-9236-1c9dfc324f38)

---------

Signed-off-by: Yarden Shoham <[email protected]>
Co-authored-by: Giteabot <[email protected]>
  • Loading branch information
yardenshoham and GiteaBot authored Feb 24, 2024
1 parent 553d46e commit 267dbb4
Showing 1 changed file with 14 additions and 11 deletions.
25 changes: 14 additions & 11 deletions web_src/js/components/ContextPopup.vue
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<script>
import $ from 'jquery';
import {SvgIcon} from '../svg.js';
import {useLightTextOnBackground} from '../utils/color.js';
import tinycolor from 'tinycolor2';
import {GET} from '../modules/fetch.js';
const {appSubUrl, i18n} = window.config;
Expand Down Expand Up @@ -80,20 +80,23 @@ export default {
});
},
methods: {
load(data) {
async load(data) {
this.loading = true;
this.i18nErrorMessage = null;
$.get(`${appSubUrl}/${data.owner}/${data.repo}/issues/${data.index}/info`).done((issue) => {
this.issue = issue;
}).fail((jqXHR) => {
if (jqXHR.responseJSON && jqXHR.responseJSON.message) {
this.i18nErrorMessage = jqXHR.responseJSON.message;
} else {
this.i18nErrorMessage = i18n.network_error;
try {
const response = await GET(`${appSubUrl}/${data.owner}/${data.repo}/issues/${data.index}/info`);
const respJson = await response.json();
if (!response.ok) {
this.i18nErrorMessage = respJson.message ?? i18n.network_error;
return;
}
}).always(() => {
this.issue = respJson;
} catch {
this.i18nErrorMessage = i18n.network_error;
} finally {
this.loading = false;
});
}
}
}
};
Expand Down

0 comments on commit 267dbb4

Please sign in to comment.