add more error handling in instruments_client

hanfeya · Nov 12, 2013 · f8897c0 · f8897c0
1 parent 3ae42fe
commit f8897c0
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/bin/instruments-client.js b/bin/instruments-client.js
@@ -8,13 +8,26 @@ var connect = function(args) {
   var client = net.connect({path: args.socket}, function() {
     var data = {event: "cmd"};
     if (args.result) {
-      data.result = JSON.parse(args.result);
+      process.stderr.write("Sending result to server: " + args.result);
+      try {
+        data.result = JSON.parse(args.result);
+      } catch (e) {
+        process.stderr.write(e.message);
+        throw e;
+      }
     }
+    process.stderr.write("Sending response to server");
     data = JSON.stringify(data);
     client.end(data, "utf8");
   });
   client.on('data', function(data) {
-    data = JSON.parse(data);
+    try {
+      data = JSON.parse(data);
+    } catch (e) {
+      process.stderr.write(e.message);
+      throw e;
+    }
+    process.stderr.write("Received response from server: " + JSON.stringify(data));
     process.stdout.write(data.nextCommand);
     client.end();
     process.exit(0);

diff --git a/lib/devices/ios/uiauto/lib/instruments_client_launcher.js b/lib/devices/ios/uiauto/lib/instruments_client_launcher.js
@@ -217,6 +217,7 @@ var sendResultAndGetNext = function(result) {
     console.log(res.stderr);
     console.log("And stdout:");
     console.log(res.stdout);
+    return null;
   }
   return res.stdout;
 };