Skip to content

Commit

Permalink
Merge pull request PecanProject#3042 from infotroph/docker-tweaks
Browse files Browse the repository at this point in the history
Docker tweaks
  • Loading branch information
robkooper authored Sep 18, 2022
2 parents 188bd1a + c9c9a6c commit c5e22c8
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 5 deletions.
4 changes: 2 additions & 2 deletions DEV-INTRO.md
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ You can submit your workflow either in the executor container or in rstudio cont
docker-compose exec executor bash
# inside the container
cd /pecan/tests
R CMD ../web/workflow.R docker.sipnet.xml
R CMD ../web/workflow.R --settings docker.sipnet.xml
```

A better way of doing this is developed as part of GSOC, in which case you can leverage of the restful interface defined, or using the new R PEcAn API package.
Expand Down Expand Up @@ -310,7 +310,7 @@ If you want to reset the pecan lib folder that is mounted across all machines, f

```
docker-compose down
docker rm pecan_lib
docker volume rm pecan_lib
```

## Linux and User permissions
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ services:

# web application. This expects the config.php to be copied from docker/web
# cp docker/web/config.docker.php web/config.php
#web:
#pecan:
# volumes:
# - 'pecan_web:/var/www/html/pecan'

Expand Down
8 changes: 7 additions & 1 deletion docker/base/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,13 @@ COPY base /pecan/base/
COPY modules /pecan/modules/
COPY models /pecan/models/

RUN cd /pecan && make && rm -rf /tmp/downloaded_packages
# install all PEcAn packages
# `make clean` is to remove artifacts copied in from host system
# (e.g. basgra.so)
RUN cd /pecan \
&& make clean \
&& make \
&& rm -rf /tmp/downloaded_packages

# COPY WORKFLOW
WORKDIR /work
Expand Down
2 changes: 1 addition & 1 deletion docker/docker-compose.example.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ services:

# mount PEcAn web folder into web server, this allows for
# editing code in PHP and immediatly test the new code.
web:
pecan:
volumes:
- ${HOME}/git/pecan/web:/var/www/html/pecan
- ${HOME}/git/pecan/docker/config.docker.php:/var/www/html/pecan/config.php
Expand Down

0 comments on commit c5e22c8

Please sign in to comment.