Skip to content

Commit

Permalink
mac80211: don't drop frames where skb->len < 24 in ieee80211_scan_rx()
Browse files Browse the repository at this point in the history
This seems to be a leftover from the old days, when we didn't support
any frames that didn't contain the full ieee802.11 header.  This is
not the case anymore.  It does not cause problems now, because they
are only dropped during scan.  But when scheduled scans get merged,
this would become a problem because we would drop all small frames
while scheduled scan is running.

To fix this, return RX_CONTINUE instead of RX_DROP_MONITOR.

Cc: Johannes Berg <[email protected]>
Signed-off-by: Luciano Coelho <[email protected]>
Signed-off-by: John W. Linville <[email protected]>
  • Loading branch information
Luciano Coelho authored and linvjw committed May 10, 2011
1 parent 729da39 commit 306fe93
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/mac80211/scan.c
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ ieee80211_scan_rx(struct ieee80211_sub_if_data *sdata, struct sk_buff *skb)
return RX_CONTINUE;

if (skb->len < 24)
return RX_DROP_MONITOR;
return RX_CONTINUE;

presp = ieee80211_is_probe_resp(fc);
if (presp) {
Expand Down

0 comments on commit 306fe93

Please sign in to comment.