Skip to content

Commit

Permalink
scripts/Makefile.build: do not reference EXTRA_CFLAGS as CFLAGS repla…
Browse files Browse the repository at this point in the history
…cement

Usage of these flags has been deprecated for nearly 4 years by:

    commit f77bf01
    Author: Sam Ravnborg <sam@neptun.(none)>
    Date:   Mon Oct 15 22:25:06 2007 +0200

        kbuild: introduce ccflags-y, asflags-y and ldflags-y

Moreover, these flags (at least EXTRA_CFLAGS) have been documented for
command line use. By default, gmake(1) do not override command line
setting, so this is likely to result in build failure or unexpected
behavior.

Do not advertise for its usage.

Cc: Sam Ravnborg <[email protected]>
Cc: [email protected]
Signed-off-by: Arnaud Lacombe <[email protected]>
Signed-off-by: Michal Marek <[email protected]>
  • Loading branch information
lacombar authored and michal42 committed Aug 31, 2011
1 parent 58238c8 commit 49c57d2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/Makefile.build
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ include $(kbuild-file)
# If the save-* variables changed error out
ifeq ($(KBUILD_NOPEDANTIC),)
ifneq ("$(save-cflags)","$(CFLAGS)")
$(error CFLAGS was changed in "$(kbuild-file)". Fix it to use EXTRA_CFLAGS)
$(error CFLAGS was changed in "$(kbuild-file)". Fix it to use ccflags-y)
endif
endif

Expand Down

0 comments on commit 49c57d2

Please sign in to comment.