Fix: accidental removal of SuspensionError

hanyeah · Oct 7, 2021 · a8d0e15 · a8d0e15
1 parent 4a84e2c
commit a8d0e15
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/errors.js b/src/errors.js
@@ -373,6 +373,9 @@ const pyExc = {
 
 Object.assign(Sk.builtin, pyExc);
 
+
+Sk.builtin.SuspensionError = simpleExtends(Exception, "SuspensionError", "Unsupported Suspension in code.");
+
 Sk.builtin.ExternalError = Sk.abstr.buildNativeClass("ExternalError", {
     constructor: function ExternalError(...args) {
         this.nativeError = args[0];

diff --git a/test/unit3/test_suspensions.py b/test/unit3/test_suspensions.py
@@ -25,6 +25,12 @@ def __contains__(self, key):
         sleep(.01)
         return bool(key)
 
+class SleepingDunderFail:
+    # __iter__ can't suspend (__next__ can)
+    def __iter__(self):
+        sleep(0.01)
+        return iter([0, 1, 2])
+
 class Test_Suspensions(unittest.TestCase):
     def test_min_max(self):
         x = [4, 1, 5]
@@ -71,6 +77,16 @@ def test_dunders(self):
         # __contains__
         self.assertFalse(0 in x)
         self.assertTrue(1 in x)
+
+    def test_suspension_error(self):
+        x = SleepingDunderFail()
+        with self.assertRaises(Exception) as e:
+            for i in x:
+                pass
+        self.assertIn("Cannot call a function that blocks or suspends", str(e.exception))
+        self.assertTrue(repr(e.exception).startswith("SuspensionError"))
+
+
 
 if __name__ == '__main__':
     unittest.main()