Use more specific validation for engine objects (#241)

hapijs · Nov 6, 2022 · 2a38189 · 2a38189
1 parent 9266d81
commit 2a38189
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/client.js b/lib/client.js
@@ -19,7 +19,7 @@ module.exports = class {
     constructor(engine, options) {
 
         Hoek.assert(engine, 'Missing catbox client engine');
-        Hoek.assert(typeof engine === 'object' || typeof engine === 'function', 'engine must be an engine object or engine prototype (function)');
+        Hoek.assert((typeof engine === 'object' && typeof engine.start === 'function') || typeof engine === 'function', 'engine must be an engine object or engine prototype (function)');
         Hoek.assert(typeof engine === 'function' || !options, 'Can only specify options with function engine config');
 
         const settings = Object.assign({}, internals.defaults, options);

diff --git a/test/client.js b/test/client.js
@@ -55,6 +55,11 @@ describe('Client', () => {
         expect(result.item).to.equal('123');
     });
 
+    it('errors on invalid instance engine', () => {
+
+        expect(() => new Catbox.Client({})).to.throw();
+    });
+
     it('passes options with default partition', () => {
 
         const client = new Catbox.Client(Connection);