Bugfix: strerror_r can return an error, and if it does, POSIX does no…

…t specify the content of the buffer
happythenewsad · Jul 7, 2014 · 109849e · 109849e
1 parent a60838d
commit 109849e
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/netbase.cpp b/src/netbase.cpp
@@ -1265,7 +1265,8 @@ std::string NetworkErrorString(int err)
 #ifdef STRERROR_R_CHAR_P /* GNU variant can return a pointer outside the passed buffer */
     s = strerror_r(err, buf, sizeof(buf));
 #else /* POSIX variant always returns message in buffer */
-    (void) strerror_r(err, buf, sizeof(buf));
+    if (strerror_r(err, buf, sizeof(buf)))
+        buf[0] = 0;
 #endif
     return strprintf("%s (%d)", s, err);
 }