FFM-8106 - initialize() will now correctly setup the SSE channel #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What Fix initialize to setup the SSE channel and/or polling. Currently it requires a 2nd call to registerEventsListener() Why Make client API more consistent with Android SDK. The 2nd call is confusing for people learning the SDK for the first time as you won't see any events after init. registerEventsListener() should not setup the SSE channel instead it should just register callbacks. Testing Manual testing with proxy and unit testing
erdirowlands
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FFM-8106 - initialize() will now correctly setup the SSE channel
What
Fix initialize to setup the SSE channel and/or polling. Currently it requires a 2nd call to registerEventsListener()
Why
Make client API more consistent with Android SDK.
The 2nd call is confusing for people learning the SDK for the first time as you won't see any events after init. registerEventsListener() should not setup the SSE channel instead it should just register callbacks.
Testing
Manual testing with proxy and unit testing