Skip to content

Commit

Permalink
fix(build): Remove unused done function arguments.
Browse files Browse the repository at this point in the history
gulp only requires receiving a done argument if a task is not returning
a stream. Doing both is unnecessary and confusing.
  • Loading branch information
mprobst committed Apr 10, 2015
1 parent 838aa2a commit 8c3007e
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -368,10 +368,12 @@ gulp.task('build/transpile.js.cjs', transpile(gulp, gulpPlugins, {
srcFolderInsertion: CONFIG.srcFolderInsertion.js
}));
gulp.task('build/transformCJSTests', function() {
return gulp.src(CONFIG.dest.js.cjs + '/angular2/test/**/*_spec.js').pipe(transformCJSTests()).pipe(gulp.dest(CONFIG.dest.js.cjs + '/angular2/test/'));
return gulp.src(CONFIG.dest.js.cjs + '/angular2/test/**/*_spec.js')
.pipe(transformCJSTests())
.pipe(gulp.dest(CONFIG.dest.js.cjs + '/angular2/test/'));
});

gulp.task('build/transpile.dart', function(done) {
gulp.task('build/transpile.dart', function() {
return gulp.src(CONFIG.transpile.src.dart)
.pipe(ts2dart.transpile())
.pipe(util.insertSrcFolder(gulpPlugins, CONFIG.srcFolderInsertion.dart))
Expand Down Expand Up @@ -723,7 +725,7 @@ gulp.task('test.server.dart', runServerDartTests(gulp, gulpPlugins, {

// -----------------
// test builders
gulp.task('test.transpiler.unittest', function (done) {
gulp.task('test.transpiler.unittest', function() {
return gulp.src('tools/transpiler/unittest/**/*.js')
.pipe(jasmine({
includeStackTrace: true
Expand Down

0 comments on commit 8c3007e

Please sign in to comment.