Skip to content

Commit

Permalink
fix(bundles): remove work-around rx.js module detection.
Browse files Browse the repository at this point in the history
Updates rx to the newest version, because a fix is needed.

Closes angular#1245
  • Loading branch information
rkirov authored and pkozlowski-opensource committed Apr 8, 2015
1 parent ca95846 commit c349eb4
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 6 deletions.
17 changes: 13 additions & 4 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -872,7 +872,13 @@ var bundleConfig = {
paths: {
"*": "dist/js/prod/es6/*.es6",
"rx/*": "node_modules/rx/*.js"
}
},
meta: {
// auto-detection fails to detect properly here - https://github.com/systemjs/builder/issues/123
'rx/dist/rx.all': {
format: 'cjs'
}
}
};

// production build
Expand Down Expand Up @@ -901,10 +907,13 @@ gulp.task('bundle.js.min', ['build.js.prod'], function() {

// development build
gulp.task('bundle.js.dev', ['build.js.dev'], function() {
return bundler.bundle(
merge(true, bundleConfig, {
var devBundleConfig = merge(true, bundleConfig);
devBundleConfig.paths =
merge(true, devBundleConfig.paths, {
"*": "dist/js/dev/es6/*.es6"
}),
});
return bundler.bundle(
devBundleConfig,
'angular2/angular2',
'./dist/build/angular2.dev.js',
{
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"gulp-modify": "0.0.4",
"gulp-replace": "^0.5.3",
"node-uuid": "1.4.x",
"rx": "2.4.6",
"rx": "2.5.1",
"selenium-webdriver": "2.45.1",
"systemjs": "^0.9.1",
"traceur": "0.0.87",
Expand Down
1 change: 0 additions & 1 deletion tools/build/bundle.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,5 @@ module.exports.bundle = function(buildConfig, moduleName, outputFile, outputConf
module.exports.modify = function(srcs, concatName) {
return gulp.src(srcs)
.pipe(concat(concatName))
.pipe(replace('use strict', '')) // remove after https://github.com/systemjs/builder/issues/123 is fixed.
.pipe(replace('sourceMappingURL', 'sourceMappingURLDisabled')) // TODO: add concat for sourceMaps
}

0 comments on commit c349eb4

Please sign in to comment.