Skip to content

Commit

Permalink
Fix Java to C++ ticker conversions (facebook#4719)
Browse files Browse the repository at this point in the history
Summary:
Added back `NO_ITERATORS` and moved `NO_ITERATOR_CREATED` to the end of `toCppTickers`.

This is a leftover fix which is needed in addition to a138e35 to correctly convert java tickers to c++ tickers. a138e35 only updated `toJavaTickerType` but both `toJavaTickerType` and `toCppTickers` need to be changed.
Pull Request resolved: facebook#4719

Differential Revision: D13208847

Pulled By: sagar0

fbshipit-source-id: 53a42f3d6ffe04034acfde972d73040b92b4c1af
  • Loading branch information
sagar0 authored and facebook-github-bot committed Nov 27, 2018
1 parent 60deb44 commit a2dec2e
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions java/rocksjni/portal.h
Original file line number Diff line number Diff line change
Expand Up @@ -3509,7 +3509,7 @@ class TickerTypeJni {
case 0x37:
return rocksdb::Tickers::RATE_LIMIT_DELAY_MILLIS;
case 0x38:
return rocksdb::Tickers::NO_ITERATOR_CREATED;
return rocksdb::Tickers::NO_ITERATORS;
case 0x39:
return rocksdb::Tickers::NUMBER_MULTIGET_CALLS;
case 0x3A:
Expand Down Expand Up @@ -3587,8 +3587,10 @@ class TickerTypeJni {
case 0x5E:
return rocksdb::Tickers::NUMBER_MULTIGET_KEYS_FOUND;
case 0x5F:
return rocksdb::Tickers::NO_ITERATOR_DELETED;
return rocksdb::Tickers::NO_ITERATOR_CREATED;
case 0x60:
return rocksdb::Tickers::NO_ITERATOR_DELETED;
case 0x61:
return rocksdb::Tickers::TICKER_ENUM_MAX;

default:
Expand Down

0 comments on commit a2dec2e

Please sign in to comment.