feat: add and use Stats.{recv_success_count, recv_failure_count}

Signed-off-by: ljedrz <[email protected]>
harshavamsi · May 5, 2021 · 86a749c · 86a749c
1 parent 9af5cf3
commit 86a749c
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 11 deletions.
diff --git a/network/src/node.rs b/network/src/node.rs
@@ -176,7 +176,10 @@ impl<S: Storage + Send + core::marker::Sync + 'static> Node<S> {
         let incoming_task = task::spawn(async move {
             loop {
                 if let Err(e) = node_clone.process_incoming_messages(&mut receiver).await {
+                    node_clone.stats.recv_failure_count.fetch_add(1, Ordering::Relaxed);
                     error!("Node error: {}", e);
+                } else {
+                    node_clone.stats.recv_success_count.fetch_add(1, Ordering::Relaxed);
                 }
             }
         });

diff --git a/network/src/stats.rs b/network/src/stats.rs
@@ -22,6 +22,10 @@ pub struct Stats {
     pub send_success_count: AtomicU64,
     /// The monotonic counter for the number of send requests that failed.
     pub send_failure_count: AtomicU64,
+    /// The number of successfully processed inbound messages.
+    pub recv_success_count: AtomicU64,
+    /// The number of inbound messages that couldn't be processed.
+    pub recv_failure_count: AtomicU64,
     /// The current number of items in the inbound channel.
     pub inbound_channel_items: AtomicU64,
     /// The number of all connection requests the node has received.

diff --git a/rpc/documentation/public_endpoints/getnodestats.md b/rpc/documentation/public_endpoints/getnodestats.md
@@ -6,17 +6,19 @@ None
 
 ### Response
 
-|            Parameter           | Type |                        Description                      |
-|:------------------------------:|:----:|:-------------------------------------------------------:|
-| `send_success_count`           | u64  | The number of successfully sent messages                |
-| `send_failure_count`           | u64  | The number of failures to send messages                 |
-| `inbound_channel_items`        | u64  | The number of inbound items queued to be processed      |
-| `inbound_connection_requests`  | u64  | The number of connection requests the node has received |
-| `outbound_connection_requests` | u64  | The number of connection requests the node has made     |
-| `number_of_connected_peers`    | u16  | The number of currently connected peers                 |
-| `number_of_connecting_peers`   | u16  | The number of currently connecting peers                |
-| `blocks_mined`                 | u32  | The number of blocks the node has mined                 |
-| `block_height`                 | u32  | The current block height of the node                    |
+|            Parameter           | Type |                         Description                       |
+|:------------------------------:|:----:|:---------------------------------------------------------:|
+| `send_success_count`           | u64  | The number of successfully sent messages                  |
+| `send_failure_count`           | u64  | The number of failures to send messages                   |
+| `recv_success_count`           | u64  | The number of successfully processed inbound messages     |
+| `recv_failure_count`           | u64  | The number of inbound messages that couldn't be processed |
+| `inbound_channel_items`        | u64  | The number of inbound items queued to be processed        |
+| `inbound_connection_requests`  | u64  | The number of connection requests the node has received   |
+| `outbound_connection_requests` | u64  | The number of connection requests the node has made       |
+| `number_of_connected_peers`    | u16  | The number of currently connected peers                   |
+| `number_of_connecting_peers`   | u16  | The number of currently connecting peers                  |
+| `blocks_mined`                 | u32  | The number of blocks the node has mined                   |
+| `block_height`                 | u32  | The current block height of the node                      |
 
 ### Example
 ```ignore

diff --git a/rpc/src/rpc_impl.rs b/rpc/src/rpc_impl.rs
@@ -321,6 +321,8 @@ impl<S: Storage + Send + core::marker::Sync + 'static> RpcFunctions for RpcImpl<
         Ok(NodeStats {
             send_success_count: self.node.stats.send_success_count.load(Ordering::Relaxed),
             send_failure_count: self.node.stats.send_failure_count.load(Ordering::Relaxed),
+            recv_success_count: self.node.stats.recv_success_count.load(Ordering::Relaxed),
+            recv_failure_count: self.node.stats.recv_failure_count.load(Ordering::Relaxed),
             inbound_channel_items: self.node.stats.inbound_channel_items.load(Ordering::SeqCst),
             inbound_connection_requests: self.node.stats.inbound_connection_requests.load(Ordering::Relaxed),
             outbound_connection_requests: self.node.stats.outbound_connection_requests.load(Ordering::Relaxed),

diff --git a/rpc/src/rpc_types.rs b/rpc/src/rpc_types.rs
@@ -138,6 +138,12 @@ pub struct NodeStats {
     /// The number of failures to send messages
     pub send_failure_count: u64,
 
+    /// The number of successfully processed inbound messages.
+    pub recv_success_count: u64,
+
+    /// The number of inbound messages that couldn't be processed.
+    pub recv_failure_count: u64,
+
     /// The number of inbound items queued to be processed
     pub inbound_channel_items: u64,