Wipe Disks Improvements #885
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihcsim
reviewed
Nov 29, 2024
ihcsim
reviewed
Dec 2, 2024
|
This pull request is now in conflict. Could you fix it @ibrokethecloud? 🙏 |
|
LGTM - can approve once conflicts are resolved. |
PR introduces two new fields in the harvester config wipeDisksList and wipeAllDisks and drops the old wipeDisks introduced in v1.3 There is an extra panel in disk configuration page. The extra panel contains a drop down menu which gets rendered and populated if installer finds additional disks with existing elemental based installations which are not already used in install device or additional data device
ibrokethecloud
force-pushed
the
wipe-disks-panel
branch
from
cba5bc3 to
8e2f3d5
Compare
ihcsim
approved these changes
Jan 17, 2025
Vicente-Cheng
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We introduced a field in Harvester config named
wipeDiskswhich when set ran a script in the installer to iterate over all disk devices visible to the host and wipe them.This ended up being too aggressive, not to mention not all disks may contain old Harvester installations.
Solution:
PR introduces two new fields in the harvester config wipeDisksList and wipeAllDisks and drops the old wipeDisks introduced in v1.3
There is an extra panel in disk configuration page. The extra panel contains a drop down menu which gets rendered and populated if installer finds additional disks with existing elemental based installations which are not already used in install device or additional data device.
The extra
Wipe Diskspanels will only be available when there are additional disks visible to the host which have a partition withCOS_OEMlabel and such disk is not already being used inInstall DeviceorInstall Data Device.User can also pass these fields via ipxe using the following two new fields
or
wipeAllDisksuses the same logic as the installersWipe Disks Panelwhere it will identify additional disks withCOS_OEMpartition which are not already being used asInstall DeviceorInstall Data Device.Related Issue:
harvester/harvester#6304
harvester/harvester#6533
Test plan: