Change composer package type to npm-asset

[hussainweb]

None of the action items in the summary below are relevant because this is a change only in composer.json. If you think otherwise, please let me know.

This PR changes the type of this project in the composer.json file. The current value of "library" is not a very good fit because that is the default for PHP libraries which are usually placed in a non-web-accessible vendor directory. Since Chosen is a JavaScript library, it needs to be accessible via web.

Now, composer doesn't support any type that indicates web asset but there is a community project called asset-packagist which utilises a type of "npm-asset". This type of project is placed in web accessible directories using other packages such as oomphinc/composer-installers-extender. Now, this is not really relevant to this change but I am adding additional context to support my case.

The above might seem convoluted but is actually regular workflow at least for Drupal projects. I believe changing the composer type makes it very straight-forward for not just Drupal but various other projects as well to use chosen. The current type presents an additional unnecessary hurdle in setting up chosen for use with PHP projects.

Summary

Provide a general description of the code changes in your pull request.

Please double-check that:

• All changes were made in CoffeeScript files, not JavaScript files.
• You used Grunt to build the JavaScript files and tested them locally.
• You've updated both the jQuery and Prototype versions.
• You haven't manually updated the version number in package.json.
• If necessary, you've updated the documentation.

See the Pull Requests section of our Contributing Guidelines for more details.

References

If your pull request is in reference to one or more open GitHub issues, please mention them here to keep the conversations linked together.

[tjschuck]

I believe none of the Chosen maintainers have any meaningfully current PHP ties, so I'm going to ping the couple of people that were primarily responsible for getting this in in the first place, since they'll probably have a more reasoned response than our ¯\_(ツ)_/¯ — @landsman and @marclaporte, if you're still around these parts, what do you think?

[hussainweb]

@tjschuck, that's completely reasonable. Thank you!

[hussainweb]

It's been a while. Anything I can do to help move this along?

[JTubex]

+1 for this change. This will make including chosen in Drupal a lot easier.

[jhedstrom]

This would be great to get in. +1

[alisonjo315]

Woo hoo! Thank you so much, everybody!

(And, issue resolved, yes?)

[ultimike]

This change would make it much easier to include in any PHP project that utilize a nested docroot (which is considered a best practice).

[mlncn]

I think the lack of maintenance of this module (as well as not addressing accessibility problems) is subconsciously driving my desire to stop using the Harvest service (along with many problems with the service itself that is consciously driving the decision).

This is a company with plenty of resources to have someone attend to this once a year.