dynamic host volumes: change env vars, fixup auto-delete #24943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gulducat
requested review from
prestonbourne
and removed request for
prestonbourne
tgross
reviewed
Jan 24, 2025
gulducat
commented
Jan 24, 2025
| // GetHostVolumePluginVersions finds all the executable files on disk that | ||
| // respond to a `fingerprint` call. The return map's keys are plugin IDs, | ||
| // and the values are version strings. | ||
| func GetHostVolumePluginVersions(log hclog.Logger, pluginDir, nodePool string) (map[string]string, error) { |
There was a problem hiding this comment.
nodepool isn't really needed in this context, because fingerprint calls don't include it, but I pass it through here anyway to avoid potential confusion in the future if someone does want to add it to fingerprint env.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This trues up plugin behavior with the spec that we arrived at in the docs PR: #24924
deletewhen saving client state fails after initialcreate, not update or restore.DHV_HOST_PATHenv, where we included the volume ID withinalloc_mounts, in favor of:DHV_VOLUMES_DIR- create and delete - configurable - where plugins should place volumes, with whatever convention they like.DHV_CREATED_PATH- delete - the"path"response from create; plugins may use this verbatim, or derive the path the same way ascreateDHV_NAMESPACEandDHV_NODE_POOLto create and deleteI confirmed that the
e2etest still passes - it only usesmkdirat the moment.I have not confirmed that the example plugin still works on MacOS.