tfexec: add InitJSON #478
Merged
tfexec: add InitJSON #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactors `tfexec/init.go` by splitting the init functions into distinct functions to facilitate the support of the new InitJSON function. Signed-off-by: Bruno Schaatsbergen <[email protected]>
The `InitJSON` and `initJSONCmd` functions append the `-json` argument to instruct the init command to write machine-readable JSON to the supplied `io.Writer`. Signed-off-by: Bruno Schaatsbergen <[email protected]>
bschaatsbergen
force-pushed
the
f/add-initjson
branch
from
a873d8a to
351f2e0
Compare
Signed-off-by: Bruno Schaatsbergen <[email protected]>
bschaatsbergen
force-pushed
the
f/add-initjson
branch
from
351f2e0 to
d7e2db6
Compare
Signed-off-by: Bruno Schaatsbergen <[email protected]>
…de positional arguments. Since the optional positional directory argument must follow all flags, as flags precede positional arguments, we append it to the args list only after all flags have been added. Signed-off-by: Bruno Schaatsbergen <[email protected]>
bschaatsbergen
force-pushed
the
f/add-initjson
branch
from
cb6532b to
1b71d09
Compare
dbanck
reviewed
Jan 20, 2025
dbanck
previously approved these changes
Jan 20, 2025
Co-authored-by: Daniel Banck <[email protected]>
Co-authored-by: Daniel Banck <[email protected]>
Co-authored-by: Daniel Banck <[email protected]>
^ it's likely there will be only one We face the same problem with |
radeksimko
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #442
tfexec/init.goto facilitate (split some code into distinct functions) the support the newInitJSONfunction, similar toApplyJSONandPlanJSON.InitJSONfunctions.