Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace mholt/archiver with mholt/archives #384

Merged
merged 2 commits into from
Jan 11, 2025

Conversation

amartin120
Copy link
Contributor

@amartin120 amartin120 commented Jan 10, 2025

Please check below, if the PR fulfills these requirements:

  • Commit(s) and code follow the repositories guidelines.
  • Test(s) have been added or updated to support these change(s).
  • Doc(s) have been added or updated to support these change(s).

Associated Links:

Types of Changes:

  • "Address CVEs" change.

Proposed Changes:

  • switch to a version of the project that's being actively maintained. i.e github.com/mholt/archives
  • has an improved, more conventional exported API, significant performance improvements, and new features.
  • pushes some implementation details to us to handle, which "can" be good.

Verification/Testing of Changes:

> hauler store save                                                                                                                                                                                                                                                            
2025-01-10 14:21:57 INF saved store [store] -> [/Users/amartin/projects/hauler/haul.tar.zst]

> rm -rf store

> hauler store load haul.tar.zst
2025-01-10 13:57:34 INF loading content from [haul.tar.zst] to [store]

> ls -la store
total 16
drwxr-xr-x@  5 amartin  staff   160 Jan 10 14:21 .
drwxr-xr-x  22 amartin  staff   704 Jan 10 14:22 ..
drwxr-xr-x@  3 amartin  staff    96 Jan 10 13:57 blobs
-rw-r--r--@  1 amartin  staff  1086 Jan 10 13:57 index.json

Additional Context:

@zackbradys zackbradys added enhancement New feature or request size/M Denotes an issue/PR requiring a relatively moderate amount of work dependencies Pull requests that update a dependency file labels Jan 10, 2025
@zackbradys zackbradys added this to the Hauler v1.2-next1 milestone Jan 10, 2025
Copy link
Member

@zackbradys zackbradys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependency overhauls for the win... LGTM!!

@zackbradys zackbradys merged commit 882713b into hauler-dev:main Jan 11, 2025
2 checks passed
@amartin120 amartin120 deleted the archiver branch February 7, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request size/M Denotes an issue/PR requiring a relatively moderate amount of work
Projects
Status: Resolved
Development

Successfully merging this pull request may close these issues.

[feature] update mholt/archiver to v4
2 participants