Skip to content

Commit

Permalink
Add Snowflake to the oracle/redshift timezone shift results in unix-t…
Browse files Browse the repository at this point in the history
…imestamp-test
  • Loading branch information
iethree committed Oct 26, 2018
1 parent 5fff41c commit aae11e2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion test/metabase/query_processor_test/date_bucketing_test.clj
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
(long x)
x))

(defn- tz-shifted-engine-bug?
(defn tz-shifted-engine-bug?
"Returns true if `engine` is affected by the bug originally observed in
Oracle (https://github.com/metabase/metabase/issues/5789) but later found in Redshift and Snowflake. The timezone is
applied correctly, but the date operations that we use aren't using that timezone. This function is used to
Expand Down
3 changes: 2 additions & 1 deletion test/metabase/query_processor_test/unix_timestamp_test.clj
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
(ns metabase.query-processor-test.unix-timestamp-test
"Tests for UNIX timestamp support."
(:require [metabase.query-processor-test :refer :all]
[metabase.query-processor-test.date-bucketing-test :as dbt]
[metabase.test
[data :as data]
[util :as tu]]
Expand Down Expand Up @@ -35,7 +36,7 @@
["2015-06-09" 7]
["2015-06-10" 9]]

(contains? #{:oracle :redshift} *engine*)
(dbt/tz-shifted-engine-bug? *engine*)
[["2015-06-01T00:00:00.000-07:00" 6]
["2015-06-02T00:00:00.000-07:00" 10]
["2015-06-03T00:00:00.000-07:00" 4]
Expand Down

0 comments on commit aae11e2

Please sign in to comment.