Change error handling to not show flow disruption errors (supabase#182)

hbela · Jul 16, 2022 · 8e0b747 · 8e0b747
1 parent beaae7d
commit 8e0b747
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 16 deletions.
diff --git a/.changeset/shaggy-jokes-remember.md b/.changeset/shaggy-jokes-remember.md
@@ -0,0 +1,6 @@
+---
+'@supabase/auth-helpers-nextjs': patch
+'@supabase/auth-helpers-sveltekit': patch
+---
+
+Change error handling to not show flow disruption errors
diff --git a/packages/nextjs/src/handlers/user.ts b/packages/nextjs/src/handlers/user.ts
@@ -83,11 +83,8 @@ export default async function handleUser(
     if (e instanceof JWTPayloadFailed) {
       logger.info('JWTPayloadFailed error has happened!');
       response.error = e.toObj();
-    } else if (e instanceof CookieNotFound) {
-      logger.warn(e.toString());
     } else if (e instanceof AuthHelperError) {
-      logger.info('AuthHelperError error has happened!');
-      logger.error(e.toString());
+      // do nothing because since this just means the user isn't logged in
     } else {
       const error = e as ApiError;
       logger.error(error.message);

diff --git a/packages/nextjs/src/utils/getUser.ts b/packages/nextjs/src/utils/getUser.ts
@@ -116,11 +116,8 @@ export default async function getUser(
     if (e instanceof JWTPayloadFailed) {
       logger.info('JWTPayloadFailed error has happened!');
       response.error = e.toObj();
-    } else if (e instanceof CookieNotFound) {
-      logger.warn(e.toString());
     } else if (e instanceof AuthHelperError) {
-      logger.info('AuthHelperError error has happened!');
-      logger.error(e.toString());
+      // do nothing, these are all just to disrupt the control flow
     } else {
       const error = e as ApiError;
       logger.error(error.message);

diff --git a/packages/sveltekit/src/handlers/session.ts b/packages/sveltekit/src/handlers/session.ts
@@ -89,11 +89,8 @@ export const handleSession = (options: HandleUserOptions = {}) => {
       if (e instanceof JWTPayloadFailed) {
         logger.info('JWTPayloadFailed error has happened!');
         event.locals.error = e.toObj();
-      } else if (e instanceof CookieNotFound) {
-        logger.warn(e.toString());
       } else if (e instanceof AuthHelperError) {
-        logger.info('AuthHelperError error has happened!');
-        logger.error(e.toString());
+        // do nothing, these are all just to disrupt the control flow
       } else {
         const error = e as ApiError;
         logger.error(error.message);

diff --git a/packages/sveltekit/src/utils/getUser.ts b/packages/sveltekit/src/utils/getUser.ts
@@ -121,11 +121,8 @@ export async function getUser(
     if (e instanceof JWTPayloadFailed) {
       logger.info('JWTPayloadFailed error has happened!');
       response.error = e.toObj();
-    } else if (e instanceof CookieNotFound) {
-      logger.warn(e.toString());
     } else if (e instanceof AuthHelperError) {
-      logger.info('AuthHelperError error has happened!');
-      logger.error(e.toString());
+      // do nothing, these are all just to disrupt the control flow
     } else {
       const error = e as ApiError;
       logger.error(error.message);