Fix some linting warnings (bluesky-social#2532)

fix some linting warnings
hboon · Jun 10, 2024 · 71e3edc · 71e3edc
1 parent 6e323fb
commit 71e3edc
Show file tree

Hide file tree

Showing 9 changed files with 11 additions and 16 deletions.
diff --git a/packages/api/src/agent.ts b/packages/api/src/agent.ts
@@ -21,7 +21,6 @@ import {
 } from './types'
 import { BSKY_LABELER_DID } from './const'
 
-const MAX_MOD_AUTHORITIES = 3
 const MAX_LABELERS = 10
 const REFRESH_SESSION = 'com.atproto.server.refreshSession'
 

diff --git a/packages/api/src/rich-text/detection.ts b/packages/api/src/rich-text/detection.ts
@@ -77,7 +77,8 @@ export function detectFacets(text: UnicodeString): Facet[] | undefined {
   {
     const re = TAG_REGEX
     while ((match = re.exec(text.utf16))) {
-      let [, leading, tag] = match
+      const leading = match[1]
+      let tag = match[2]
 
       if (!tag) continue
 

diff --git a/packages/api/src/rich-text/util.ts b/packages/api/src/rich-text/util.ts
@@ -8,4 +8,5 @@ export const TRAILING_PUNCTUATION_REGEX = /\p{P}+$/gu
  * `\u00AD\u2060\u200A\u200B\u200C\u200D\u20e2` zero-width spaces (likely incomplete)
  */
 export const TAG_REGEX =
+  // eslint-disable-next-line no-misleading-character-class
   /(^|\s)[#＃]((?!\ufe0f)[^\s\u00AD\u2060\u200A\u200B\u200C\u200D\u20e2]*[^\d\s\p{P}\u00AD\u2060\u200A\u200B\u200C\u200D\u20e2]+[^\s\u00AD\u2060\u200A\u200B\u200C\u200D\u20e2]*)?/gu
diff --git a/packages/api/src/util.ts b/packages/api/src/util.ts
@@ -4,10 +4,13 @@ import { TID } from '@atproto/common-web'
 import { AppBskyActorDefs } from './client'
 
 export function sanitizeMutedWordValue(value: string) {
-  return value
-    .trim()
-    .replace(/^#(?!\ufe0f)/, '')
-    .replace(/[\r\n\u00AD\u2060\u200D\u200C\u200B]+/, '')
+  return (
+    value
+      .trim()
+      .replace(/^#(?!\ufe0f)/, '')
+      // eslint-disable-next-line no-misleading-character-class
+      .replace(/[\r\n\u00AD\u2060\u200D\u200C\u200B]+/, '')
+  )
 }
 
 export function savedFeedsToUriArrays(

diff --git a/packages/api/tests/moderation-quoteposts.test.ts b/packages/api/tests/moderation-quoteposts.test.ts
@@ -1,5 +1,4 @@
 import {
-  moderateProfile,
   moderatePost,
   mock,
   ModerationOpts,

diff --git a/packages/bsky/tests/label-hydration.test.ts b/packages/bsky/tests/label-hydration.test.ts
@@ -4,7 +4,6 @@ import axios from 'axios'
 
 describe('label hydration', () => {
   let network: TestNetwork
-  let agent: AtpAgent
   let pdsAgent: AtpAgent
   let sc: SeedClient
 
@@ -17,7 +16,6 @@ describe('label hydration', () => {
     network = await TestNetwork.create({
       dbPostgresSchema: 'bsky_label_hydration',
     })
-    agent = network.bsky.getClient()
     pdsAgent = network.pds.getClient()
     sc = network.getSeedClient()
     await basicSeed(sc)

diff --git a/packages/bsky/tests/query-labels.test.ts b/packages/bsky/tests/query-labels.test.ts
@@ -1,10 +1,8 @@
 import { AtpAgent } from '@atproto/api'
 import { TestNetwork, SeedClient, basicSeed } from '@atproto/dev-env'
-import axios from 'axios'
 
 describe('label hydration', () => {
   let network: TestNetwork
-  let agent: AtpAgent
   let pdsAgent: AtpAgent
   let sc: SeedClient
 
@@ -17,7 +15,6 @@ describe('label hydration', () => {
     network = await TestNetwork.create({
       dbPostgresSchema: 'bsky_label_hydration',
     })
-    agent = network.bsky.getClient()
     pdsAgent = network.pds.getClient()
     sc = network.getSeedClient()
     await basicSeed(sc)

diff --git a/packages/ozone/tests/lang.test.ts b/packages/ozone/tests/lang.test.ts
@@ -4,12 +4,10 @@ import {
   TestNetwork,
   basicSeed,
 } from '@atproto/dev-env'
-import AtpAgent from '@atproto/api'
 import { REASONSPAM } from '../src/lexicon/types/com/atproto/moderation/defs'
 
 describe('moderation status language tagging', () => {
   let network: TestNetwork
-  let agent: AtpAgent
   let sc: SeedClient
   let modClient: ModeratorClient
 
@@ -21,7 +19,6 @@ describe('moderation status language tagging', () => {
         blobDivertAdminPassword: 'test-auth-token',
       },
     })
-    agent = network.pds.getClient()
     sc = network.getSeedClient()
     modClient = network.ozone.getModClient()
     await basicSeed(sc)

diff --git a/packages/pds/tests/handle-validation.test.ts b/packages/pds/tests/handle-validation.test.ts
@@ -34,7 +34,7 @@ describe('handle validation', () => {
     const expectThrow = (handle: string, err: string) => {
       expect(() => ensureHandleServiceConstraints(handle, domains)).toThrow(err)
     }
-    const expectNotThrow = (handle: string, memo: string) => {
+    const expectNotThrow = (handle: string, _memo: string) => {
       expect(() =>
         ensureHandleServiceConstraints(handle, domains),
       ).not.toThrow()