Skip to content

Commit

Permalink
Fix Prometheus metrics provider package name (apache#1868)
Browse files Browse the repository at this point in the history
  • Loading branch information
merlimat authored May 30, 2018
1 parent ecec933 commit 2710586
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 8 deletions.
3 changes: 1 addition & 2 deletions deployment/dcos/PulsarGroups.json
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
"// Notice": "add PULSAR_MEM, PULSAR_GC, according to your environment.",
"zkServers": "master.mesos:2181",
"ledgerManagerType": "hierarchical",
"statsProviderClass": "org.apache.bookkeeper.stats.PrometheusMetricsProvider",
"statsProviderClass": "org.apache.bookkeeper.stats.prometheus.PrometheusMetricsProvider",
"journalDirectory": "/bookkeeper/data/journal",
"ledgerDirectories": "/bookkeeper/data/ledgers",
"indexDirectories": "/bookkeeper/data/index"
Expand Down Expand Up @@ -348,4 +348,3 @@
}
]
}

2 changes: 1 addition & 1 deletion deployment/kubernetes/aws/bookkeeper.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ data:
dbStorage_rocksDB_blockCacheSize: "4294967296"
journalMaxSizeMB: "2048"
zkServers: zk-0.zookeeper,zk-1.zookeeper,zk-2.zookeeper
statsProviderClass: org.apache.bookkeeper.stats.PrometheusMetricsProvider
statsProviderClass: org.apache.bookkeeper.stats.prometheus.PrometheusMetricsProvider
useHostNameAsBookieID: "true"
---
apiVersion: apps/v1beta1
Expand Down
2 changes: 1 addition & 1 deletion deployment/kubernetes/generic/bookie.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ data:
dbStorage_writeCacheMaxSizeMb: "256" # Write cache size (direct memory)
dbStorage_readAheadCacheMaxSizeMb: "256" # Read cache size (direct memory)
zkServers: zk-0.zookeeper,zk-1.zookeeper,zk-2.zookeeper
statsProviderClass: org.apache.bookkeeper.stats.PrometheusMetricsProvider
statsProviderClass: org.apache.bookkeeper.stats.prometheus.PrometheusMetricsProvider
---

## BookKeeper servers need to access the local disks and the pods
Expand Down
4 changes: 2 additions & 2 deletions deployment/kubernetes/google-kubernetes-engine/bookie.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ data:
dbStorage_writeCacheMaxSizeMb: "1024"
dbStorage_readAheadCacheMaxSizeMb: "1024"
zkServers: zk-0.zookeeper,zk-1.zookeeper,zk-2.zookeeper
statsProviderClass: org.apache.bookkeeper.stats.PrometheusMetricsProvider
statsProviderClass: org.apache.bookkeeper.stats.prometheus.PrometheusMetricsProvider
useHostNameAsBookieID: "true"
---
apiVersion: apps/v1beta1
Expand Down Expand Up @@ -109,7 +109,7 @@ spec:
hostPort: 3181
name: client
envFrom:
- configMapRef:
- configMapRef:
name: bookie-config
volumeMounts:
- name: journal-disk
Expand Down
2 changes: 1 addition & 1 deletion deployment/terraform-ansible/templates/bookkeeper.conf
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ writeBufferSizeBytes=65536
useHostNameAsBookieID=false

# Stats Provider Class
statsProviderClass=org.apache.bookkeeper.stats.PrometheusMetricsProvider
statsProviderClass=org.apache.bookkeeper.stats.prometheus.PrometheusMetricsProvider
# Default port for Prometheus metrics exporter
prometheusStatsHttpPort=8000

Expand Down
2 changes: 1 addition & 1 deletion site/_data/config/bookkeeper.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ configs:
description: |
Whether the bookie should use its hostname to register with the coordination service (e.g.: zookeeper service). When `false`, bookie will use its ipaddress for the registration.
- name: statsProviderClass
default: org.apache.bookkeeper.stats.PrometheusMetricsProvider
default: org.apache.bookkeeper.stats.prometheus.PrometheusMetricsProvider
- name: prometheusStatsHttpPort
default: 8000
- name: dbStorage_writeCacheMaxSizeMb
Expand Down

0 comments on commit 2710586

Please sign in to comment.