Skip to content

Commit

Permalink
Fix set-project-version.sh (apache#3847)
Browse files Browse the repository at this point in the history
*Motivation*

The script doesn't update the parent version for protobuf-shaded module

*Modifications*

use `versions:update-parent` to update parent version
  • Loading branch information
sijie authored Mar 19, 2019
1 parent be97a4c commit aace3e5
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/set-project-version.sh
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ pushd $(dirname "$0")/..
mvn versions:set -DnewVersion=$NEW_VERSION
mvn versions:set -DnewVersion=$NEW_VERSION -pl buildtools
mvn versions:set -DnewVersion=$NEW_VERSION -pl pulsar-sql/presto-distribution
# install the new version of root pom local, so `update-parent` can update the right parent version
mvn -am -pl . clean install -DskipTests
mvn versions:update-parent -DallowSnapshots=true -DparentVersion=$NEW_VERSION -f protobuf-shaded/pom.xml
mvn versions:set -DnewVersion=$NEW_VERSION -f protobuf-shaded/pom.xml

popd

0 comments on commit aace3e5

Please sign in to comment.