Add extra logging and fix healthcheck disable

hdm7577 · Mar 23, 2022 · a3607b1 · a3607b1
1 parent e98d148
commit a3607b1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/packages/arb-rpc-node/cmd/arb-node/arb-node.go b/packages/arb-rpc-node/cmd/arb-node/arb-node.go
@@ -225,12 +225,14 @@ func startup() error {
 	healthChan <- nodehealth.Log{Config: true, Var: "openethereumHealthcheckRPC", ValStr: config.L1.URL}
 	nodehealth.Init(healthChan)
 
-	go func() {
-		err := nodehealth.StartNodeHealthCheck(ctx, healthChan, metricsConfig.Registry)
-		if err != nil {
-			log.Error().Err(err).Msg("healthcheck server failed")
-		}
-	}()
+	if config.Healthcheck.Enable {
+		go func() {
+			err := nodehealth.StartNodeHealthCheck(ctx, healthChan, metricsConfig.Registry)
+			if err != nil {
+				log.Error().Err(err).Msg("healthcheck server failed")
+			}
+		}()
+	}
 
 	var sequencerFeed chan broadcaster.BroadcastFeedMessage
 	if len(config.Feed.Input.URLs) == 0 {

diff --git a/packages/arb-util/ethutils/client.go b/packages/arb-util/ethutils/client.go
@@ -19,6 +19,7 @@ package ethutils
 import (
 	"context"
 	"encoding/json"
+	"github.com/rs/zerolog/log"
 	"math/big"
 	"sync"
 	"sync/atomic"
@@ -107,6 +108,7 @@ func (r *RPCEthClient) handleCallErr(err error) error {
 
 	// If we've had above a threshold number of errors, reinitialize the connection
 	if totalErrCount >= maxErrCount {
+		log.Warn().Err(err).Str("url", r.url).Msg("Reconnecting to client endpoint after repeated errors")
 		if err := r.reconnect(); err != nil {
 			return err
 		}