Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: add Chooser componnent stories #2824

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

Faakhir30
Copy link
Contributor

References #931

Added clusterChooser components stories.

Heres snapshots video of current state:
Screencast from 2025-02-01 04-10-54.webm

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Feb 1, 2025
Copy link
Contributor

@sniok sniok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice changes, thanks! could you take a look into LoadingClusters story and why there are clusters in the output?

@Faakhir30 Faakhir30 force-pushed the feat/new-chooser-stories branch from 78d6cc3 to 9bc15bd Compare February 3, 2025 21:46
@Faakhir30 Faakhir30 requested a review from sniok February 3, 2025 21:49
@Faakhir30 Faakhir30 force-pushed the feat/new-chooser-stories branch from 9bc15bd to 326d0d1 Compare February 4, 2025 00:02
@Faakhir30 Faakhir30 force-pushed the feat/new-chooser-stories branch from 326d0d1 to f2a8b4a Compare February 4, 2025 14:54
@Faakhir30 Faakhir30 requested a review from sniok February 4, 2025 14:57
Signed-off-by: Faakhir30 <[email protected]>
@Faakhir30 Faakhir30 force-pushed the feat/new-chooser-stories branch from f2a8b4a to 1756226 Compare February 4, 2025 15:59
@Faakhir30
Copy link
Contributor Author

Force pushed again, since e2e tests timed out after 13 min

Copy link
Contributor

@sniok sniok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

Copy link
Collaborator

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎈

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 7, 2025
@illume illume merged commit 617474e into headlamp-k8s:main Feb 7, 2025
15 checks passed
@Faakhir30 Faakhir30 deleted the feat/new-chooser-stories branch February 7, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants