Add validations to prevent 500s with malformed URLs (#529)

* Add validations to prevent 500s with malformed URLs.

* Use built-in Flask type validators.J

app.py

@@ -524,8 +524,8 @@ def index(level, step):
         adventure_name=adventure_name)
 
 @app.route('/onlinemasters', methods=['GET'], defaults={'level': 1, 'step': 1})
-@app.route('/onlinemasters/<level>', methods=['GET'], defaults={'step': 1})
-@app.route('/onlinemasters/<level>/<step>', methods=['GET'])
+@app.route('/onlinemasters/<int:level>', methods=['GET'], defaults={'step': 1})
+@app.route('/onlinemasters/<int:level>/<int:step>', methods=['GET'])
 def onlinemasters(level, step):
     g.level = level = int(level)
     g.lang = lang = requested_lang()
@@ -547,8 +547,8 @@ def onlinemasters(level, step):
         adventure_name='')
 
 @app.route('/space_eu', methods=['GET'], defaults={'level': 1, 'step': 1})
-@app.route('/space_eu/<level>', methods=['GET'], defaults={'step': 1})
-@app.route('/space_eu/<level>/<step>', methods=['GET'])
+@app.route('/space_eu/<int:level>', methods=['GET'], defaults={'step': 1})
+@app.route('/space_eu/<int:level>/<int:step>', methods=['GET'])
 def space_eu(level, step):
     g.level = level = int(level)
     g.lang = requested_lang()

website/querylog.py

@@ -140,7 +140,9 @@ def finish_global_log_record(exc=None):
 
 def log_value(**kwargs):
     """Log values into the currently globally active Log Record."""
-    THREAD_LOCAL.current_log_record.set(**kwargs)
+    if hasattr(THREAD_LOCAL, 'current_log_record'):
+        # For some malformed URLs, the records are not initialized, so we check whether there's a current_log_record
+        THREAD_LOCAL.current_log_record.set(**kwargs)
 
 
 def log_time(name):