core: fix use of uninitialized variable for object size

By default it is now assigned to OBJECT_SIZE_UNKNOWN so the plugins are only necessary to change its size if they really know the size of object.
heinervdm · Jul 6, 2010 · f6ec4d5 · f6ec4d5
1 parent 8a14edd
commit f6ec4d5
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 13 deletions.
diff --git a/plugins/filesystem.c b/plugins/filesystem.c
@@ -323,9 +323,6 @@ static void *capability_open(const char *name, int oflag, mode_t mode,
 
 	object->watch = g_child_watch_add(object->pid, script_exited, object);
 
-	if (size)
-		*size = 1;
-
 done:
 	if (err)
 		*err = 0;

diff --git a/plugins/pbap.c b/plugins/pbap.c
@@ -698,9 +698,6 @@ static void *vobject_pull_open(const char *name, int oflag, mode_t mode,
 	if (ret < 0)
 		goto fail;
 
-	if (size)
-		*size = OBJECT_SIZE_UNKNOWN;
-
 	return pbap;
 
 fail:
@@ -737,9 +734,6 @@ static void *vobject_list_open(const char *name, int oflag, mode_t mode,
 		goto fail;
 
 done:
-	if (size)
-		*size = OBJECT_SIZE_UNKNOWN;
-
 	return pbap;
 
 fail:
@@ -789,9 +783,6 @@ static void *vobject_vcard_open(const char *name, int oflag, mode_t mode,
 	if (ret < 0)
 		goto fail;
 
-	if (size)
-		*size = OBJECT_SIZE_UNKNOWN;
-
 	return pbap;
 
 fail:

diff --git a/src/obex.c b/src/obex.c
@@ -729,7 +729,7 @@ int obex_get_stream_start(struct obex_session *os, const char *filename)
 {
 	int err;
 	void *object;
-	size_t size;
+	size_t size = OBJECT_SIZE_UNKNOWN;
 
 	object = os->driver->open(filename, O_RDONLY, 0, os->service_data,
 								&size, &err);