Skip to content

Commit

Permalink
refactor prealpha-env to scrollEnvironment
Browse files Browse the repository at this point in the history
  • Loading branch information
OrestTa committed Mar 8, 2023
1 parent 042f19c commit c82e29b
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 8 deletions.
6 changes: 3 additions & 3 deletions .github/ISSUE_TEMPLATE/add_token.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@ title: '[Token]: '
labels: ['new', 'checked']
body:
- type: dropdown
id: prealphaEnv
id: scrollEnvironment
attributes:
label: prealphaEnv
description: The token will show in main/staging scroll testnet environment
label: scrollEnvironment
description: The token will show in main/staging scroll testnet environment (ref)
options:
- alpha
- develop
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/issue-to-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
- uses: actions/checkout@v3
with:
fetch-depth: 0
ref: ${{ steps.parse-token.outputs.prealpha-env }}
ref: ${{ steps.parse-token.outputs.scrollEnvironment }}

- name: Use Node.js 16.x
uses: actions/setup-node@v3
Expand All @@ -64,7 +64,7 @@ jobs:
title: '[New Token] name: ${{ steps.issue-parser.outputs.issueparser_name }}'
body: 'Refer Issue: #${{ github.event.issue.number }}'
commit-message: add ${{ steps.issue-parser.outputs.issueparser_symbol }}
base: ${{ steps.parse-token.outputs.prealpha-env }}
base: ${{ steps.parse-token.outputs.scrollEnvironment }}
branch: new-token/${{ steps.issue-parser.outputs.issueparser_symbol }}
delete-branch: true
add-paths: scroll.tokenlist.json
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
![e2pYC.png](https://i.328888.xyz/2023/02/27/e2pYC.png)
Please fill form like below.
![e2ecc.png](https://i.328888.xyz/2023/02/27/e2ecc.png)
`prealphaEnv` field determines which environment's token list you will modify, be careful.

`scrollEnvironment` field determines which environment's (ref) token list you will modify, be careful.

2. After click **Submit new issue**, a PR will be opened to add a new token to token list. when the PR is merged(Scroll Team will handle it as soon as possible), you need to wait another 5 minutes and refresh the page to see the new token.
![eHDqE.png](https://i.328888.xyz/2023/02/27/eHDqE.png)
4 changes: 2 additions & 2 deletions scripts/parseToken.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import * as core from '@actions/core';
(async () => {
try {
const token = JSON.parse(process.env.RESOLVED_TOKEN_STR);
const { prealphaEnv, chainId, address, name, symbol, decimals, logoURI } =
const { scrollEnvironment, chainId, address, name, symbol, decimals, logoURI } =
token;
const newtoken = {
chainId: parseInt(chainId),
Expand All @@ -13,7 +13,7 @@ import * as core from '@actions/core';
decimals: parseInt(decimals),
logoURI,
};
core.setOutput('prealpha-env', prealphaEnv);
core.setOutput('scrollEnvironment', scrollEnvironment);
core.setOutput('new-token', JSON.stringify(newtoken, null, 2));
process.exit(0);
} catch (e) {
Expand Down

0 comments on commit c82e29b

Please sign in to comment.