QHash: Add and use a Bucket helper class

Introduces a QHashPrivate::Data::Bucket class. This class helps avoid repeated bitshift and masking operations when locating bucket entries in the hash. Change signature of some internal methods to use Bucket instead of the private iterator, so we can avoid repeated encoding/decoding steps for the bucket index. Task-number: QTBUG-91739 Task-number: QTBUG-98436 Change-Id: I9ed2205bf886f9c20a5be109fd88456eec4d1540 Reviewed-by: Marc Mutz <[email protected]> Reviewed-by: Thiago Macieira <[email protected]>
helloworld0709 · Dec 17, 2021 · 9c9cdbe · 9c9cdbe
1 parent 340b2a1
commit 9c9cdbe
Show file tree

Hide file tree

Showing 2 changed files with 173 additions and 97 deletions.
diff --git a/src/corelib/tools/qcache.h b/src/corelib/tools/qcache.h
@@ -138,7 +138,7 @@ class QCache
         n->prev->next = n->next;
         n->next->prev = n->prev;
         total -= n->value.cost;
-        auto it = d.find(n->key);
+        auto it = d.findBucket(n->key);
         d.erase(it);
     }
     T *relink(const Key &key) const noexcept