Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ban !flag outside #bot-spam #15

Merged
merged 3 commits into from
Nov 5, 2023
Merged

Ban !flag outside #bot-spam #15

merged 3 commits into from
Nov 5, 2023

Conversation

101arrowz
Copy link
Contributor

No description provided.

@henry9836 henry9836 self-requested a review November 5, 2023 04:44
henry9836
henry9836 requested changes Nov 5, 2023
View reviewed changes
Copy link
Owner

@henry9836 henry9836 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c

henry9836
henry9836 requested changes Nov 5, 2023
View reviewed changes
Copy link
Owner

@henry9836 henry9836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't use hardcoded ids, please add a setter for botConfig to add a botspam channel and utilise that under the channels section.

e.g botConfig.channels.botspam

util/discordModules/eggModule.js Show resolved Hide resolved
henry9836
henry9836 requested changes Nov 5, 2023
View reviewed changes
Copy link
Owner

@henry9836 henry9836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but the new setter command needs to be added to the admin help dialog then should be good to be approved

@henry9836 henry9836 merged commit 6a4d877 into henry9836:main Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henry9836 henry9836 henry9836 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@101arrowz @henry9836