Skip to content

Commit

Permalink
HID: sensor-hub: Allow multi-function sensor devices
Browse files Browse the repository at this point in the history
The Lenovo Yoga C630 has a combined keyboard and accelerometer that
interfaces via i2c-hid. Currently this laptop either has a working
keyboard (if CONFIG_HID_SENSOR_HUB is disabled) or a working accelerometer.
only works on kernels. Put another way, most distro kernels enable
CONFIG_HID_SENSOR_HUB and therefore cannot work on this device since the
keyboard doesn't work!

Fix this by providing a richer connect mask during the probe. With this
change both keyboard and screen orientation sensors work correctly.

Signed-off-by: Daniel Thompson <[email protected]>
Acked-by: Srinivas Pandruvada<[email protected]>
Signed-off-by: Jiri Kosina <[email protected]>
  • Loading branch information
daniel-thompson authored and Jiri Kosina committed Aug 14, 2023
1 parent 1d75460 commit 666cf30
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/hid/hid-sensor-hub.c
Original file line number Diff line number Diff line change
Expand Up @@ -632,7 +632,7 @@ static int sensor_hub_probe(struct hid_device *hdev,
}
INIT_LIST_HEAD(&hdev->inputs);

ret = hid_hw_start(hdev, 0);
ret = hid_hw_start(hdev, HID_CONNECT_DEFAULT);
if (ret) {
hid_err(hdev, "hw start failed\n");
return ret;
Expand Down

0 comments on commit 666cf30

Please sign in to comment.