Ensure the caption shortcode outputs a valid HTML ID.

fixes #33179. Built from https://develop.svn.wordpress.org/trunk@33489 git-svn-id: http://core.svn.wordpress.org/trunk@33456 1a063a9b-81f0-0310-95a4-ce76da25c4cd
here · Jul 29, 2015 · d22adb0 · d22adb0
1 parent bf9d148
commit d22adb0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/wp-includes/media.php b/wp-includes/media.php
@@ -896,7 +896,7 @@ function img_caption_shortcode( $attr, $content = null ) {
 		return $content;
 
 	if ( ! empty( $atts['id'] ) )
-		$atts['id'] = 'id="' . esc_attr( $atts['id'] ) . '" ';
+		$atts['id'] = 'id="' . esc_attr( sanitize_html_class( $atts['id'] ) ) . '" ';
 
 	$class = trim( 'wp-caption ' . $atts['align'] . ' ' . $atts['class'] );
 

diff --git a/wp-includes/version.php b/wp-includes/version.php
@@ -4,7 +4,7 @@
  *
  * @global string $wp_version
  */
-$wp_version = '4.3-beta4-33488';
+$wp_version = '4.3-beta4-33489';
 
 /**
  * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.