Beta #10
Beta #10
Conversation
| @@ -102,5 +99,5 @@ def get_any_deal(deal): | |||
| output["daydeal_weekly"] = deals[2] | |||
| output["blickdeal"] = deals[3] | |||
| output["galaxus"] = deals[4] | |||
| with open("/var/www/alldeals/frontend/deals.json", "w") as f: | |||
| with open("/var/www/alldeals-beta/frontend/deals.json", "w") as f: | |||
There was a problem hiding this comment.
Maybe we should make this relative and/or separate frontend and backend again
There was a problem hiding this comment.
I would be in favor of separating frontend and backend more clearly again. I am not a big fan of the data provider updating the frontend. Having the backend providing the data via API and the frontend consuming the data from the API as originally would be more layered architecture compliant.
There was a problem hiding this comment.
Yes, let's create an issue for that and work on it at some point.
| $isexpired = ($data[$key]['availability']=='0%' ? 'expired' : ''); | ||
|
|
||
| $htmloutput.='<div class="deal_badge' .$isexpired.'"> | ||
| <div class="progress" data-label="'.$data[$key]['availability'].'" style="border-color: '.$brandcolors[$key].'; text-shadow: -1px -1px 0 '.$brandcolors[$key].', 0 -1px 0'.$brandcolors[$key].', 1px -1px 0 '.$brandcolors[$key].', 1px 0 0 '.$brandcolors[$key].', 1px 1px 0 '.$brandcolors[$key].', 0 1px 0 '.$brandcolors[$key].', -1px 1px 0 '.$brandcolors[$key].', -1px 0 0'.$brandcolors[$key].';"> |
There was a problem hiding this comment.
Maybe we should use a templating engine like twig for such large text blobs as it becomes unreadable pretty quick
There was a problem hiding this comment.
In my opinion the only thing that would make this section hard to read is the lack of code hightlighting on the HTML attributes since it is represented as a string. I don't have any experience with templating engines nevertheless I doubt they make things easier on this scale.
api unifying implemented in backend & frontend